[PR #16348] [MERGED] FEAT: add label to settings modal controls #24109

New Issue

GiteaMirror · 2026-04-20T05:14:36-05:00

GiteaMirror commented

2026-04-20 05:14:36 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/16348
Author: @sinejespersen
Created: 8/7/2025
Status: ✅ Merged
Merged: 8/7/2025
Merged by: @tjbck

Base: dev ← Head: feature/add-label-to-settings-modal-controls

📝 Commits (1)

8d6c1c4 add aria labels to controls in interface modal

📊 Changes

2 files changed (+80 additions, -41 deletions)

View changed files

📝 src/lib/components/chat/Settings/Interface.svelte (+78 -41)
📝 src/lib/components/common/Switch.svelte (+2 -0)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

https://github.com/open-webui/open-webui/discussions/8908

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Add aria-labelledby with state to controls in the interface tab of the settings modal

Added

Add aria-labelledby with state to controls in the interface tab of the settings modal

Changed

N/A

Deprecated

N/A

Removed

N/A

Fixed

N/A

Security

N/A

Breaking Changes

N/A

Additional Information

N/A

Screenshots or Videos

N/A

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/16348 **Author:** [@sinejespersen](https://github.com/sinejespersen) **Created:** 8/7/2025 **Status:** ✅ Merged **Merged:** 8/7/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `feature/add-label-to-settings-modal-controls` --- ### 📝 Commits (1) - [`8d6c1c4`](https://github.com/open-webui/open-webui/commit/8d6c1c497f0e99d7ca089880fa65dd9e0456edd6) add aria labels to controls in interface modal ### 📊 Changes **2 files changed** (+80 additions, -41 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/chat/Settings/Interface.svelte` (+78 -41) 📝 `src/lib/components/common/Switch.svelte` (+2 -0) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. https://github.com/open-webui/open-webui/discussions/8908 **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [X] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ ] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Add `aria-labelledby` with state to controls in the interface tab of the settings modal ### Added - Add `aria-labelledby` with state to controls in the interface tab of the settings modal ### Changed N/A ### Deprecated N/A ### Removed N/A ### Fixed N/A ### Security N/A ### Breaking Changes N/A --- ### Additional Information N/A ### Screenshots or Videos N/A ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-20 05:14:36 -05:00

GiteaMirror closed this issue

2026-04-20 05:14:36 -05:00

GiteaMirror referenced this issue

2026-04-25 09:53:43 -05:00

[GH-ISSUE #24109] feat: 7-day daily API cost chart with budget tracking and monthly pace projection #35718

GiteaMirror referenced this issue

2026-05-06 00:17:46 -05:00

[GH-ISSUE #24109] feat: 7-day daily API cost chart with budget tracking and monthly pace projection #58856

Sign in to join this conversation.