github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-05-06 10:58:17 -05:00
Code Issues 1.3k Packages Projects Releases 126 Wiki Activity

[PR #15466] [MERGED] Feat: accessibility in dropdown model selector #23842

New Issue
Closed
opened 2026-04-20 05:04:31 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 05:04:31 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/15466
Author: @sinejespersen
Created: 7/2/2025
Status: ✅ Merged
Merged: 7/2/2025
Merged by: @tjbck

Base: dev ← Head: feature/accessibility-dropdown-model-selector

📝 Commits (5)

  • e5435c6 high contrast mode on model selector to enhance accessibility
  • bed2c7e remove nested buttons, as this is not valid html
  • 64b583d add margin to make outline visible
  • 6a644cd aria hidden on svg, as this is decorative
  • d7f247d make margin depend on high contrast mode, based on comment on pr

📊 Changes

3 files changed (+11 additions, -6 deletions)

View changed files

📝 src/lib/components/chat/ModelSelector.svelte (+1 -1)
📝 src/lib/components/chat/ModelSelector/Selector.svelte (+9 -5)
📝 src/lib/components/icons/ChevronDown.svelte (+1 -0)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

https://github.com/open-webui/open-webui/discussions/8908

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests to validate the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Added

  • Add margin to make outline visible
  • Add outline on high contrast mode
  • aria-hidden on decorative element

Changed

Deprecated

N/A

Removed

N/A

Fixed

N/A

Security

N/A

Breaking Changes

N/A

Additional Information

N/A

Screenshots or Videos

Screenshot 2025-07-01 at 20 50 36

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/15466 **Author:** [@sinejespersen](https://github.com/sinejespersen) **Created:** 7/2/2025 **Status:** ✅ Merged **Merged:** 7/2/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `feature/accessibility-dropdown-model-selector` --- ### 📝 Commits (5) - [`e5435c6`](https://github.com/open-webui/open-webui/commit/e5435c648088fdf807ff506f922f48f37d16ffd4) high contrast mode on model selector to enhance accessibility - [`bed2c7e`](https://github.com/open-webui/open-webui/commit/bed2c7e34f5988bb4646f6a81190596fd154bb35) remove nested buttons, as this is not valid html - [`64b583d`](https://github.com/open-webui/open-webui/commit/64b583dc290ad7a2d742584f377f41f05d67dbb3) add margin to make outline visible - [`6a644cd`](https://github.com/open-webui/open-webui/commit/6a644cd03a0470e6517bd21599b786c4f7117e37) aria hidden on svg, as this is decorative - [`d7f247d`](https://github.com/open-webui/open-webui/commit/d7f247d7d2e7de5a5a80b3853960b2298f179ed8) make margin depend on high contrast mode, based on comment on pr ### 📊 Changes **3 files changed** (+11 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/chat/ModelSelector.svelte` (+1 -1) 📝 `src/lib/components/chat/ModelSelector/Selector.svelte` (+9 -5) 📝 `src/lib/components/icons/ChevronDown.svelte` (+1 -0) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. https://github.com/open-webui/open-webui/discussions/8908 **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ ] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [ ] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Add margin to make outline visible - Add outline on high contrast mode - `aria-hidden` on decorative element - Make nested button a div, as a button [there must be no interactive content descendant and no descendant with the tabindex attribute specified.](https://html.spec.whatwg.org/multipage/form-elements.html#the-button-element) ### Added - Add margin to make outline visible - Add outline on high contrast mode - `aria-hidden` on decorative element ### Changed - Make nested button a div, as a button [there must be no interactive content descendant and no descendant with the tabindex attribute specified.](https://html.spec.whatwg.org/multipage/form-elements.html#the-button-element) ### Deprecated N/A ### Removed N/A ### Fixed N/A ### Security N/A ### Breaking Changes N/A --- ### Additional Information N/A ### Screenshots or Videos <img width="637" alt="Screenshot 2025-07-01 at 20 50 36" src="https://github.com/user-attachments/assets/9ce42588-f615-4137-825f-293064540f20" /> ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 05:04:31 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#23842
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?