github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-05-06 10:58:17 -05:00
Code Issues 1.3k Packages Projects Releases 126 Wiki Activity

[PR #15314] [MERGED] refac: Spinner and XMark components #23790

New Issue
Closed
opened 2026-04-20 05:02:15 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 05:02:15 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/15314
Author: @silentoplayz
Created: 6/25/2025
Status: ✅ Merged
Merged: 6/27/2025
Merged by: @tjbck

Base: dev ← Head: spinner-and-xmark-icon-components

📝 Commits (2)

  • d1e3940 refac: Spinner and XMark components
  • f429dd6 chore: remove comment

📊 Changes

40 files changed (+115 additions, -778 deletions)

View changed files

📝 src/lib/components/AddConnectionModal.svelte (+4 -34)
📝 src/lib/components/AddServerModal.svelte (+4 -35)
📝 src/lib/components/ChangelogModal.svelte (+3 -11)
📝 src/lib/components/ImportModal.svelte (+4 -33)
📝 src/lib/components/admin/Evaluations/FeedbackModal.svelte (+2 -10)
📝 src/lib/components/admin/Evaluations/LeaderboardModal.svelte (+2 -10)
📝 src/lib/components/admin/Settings/Audio.svelte (+2 -27)
📝 src/lib/components/admin/Settings/Connections/ManageOllamaModal.svelte (+2 -10)
📝 src/lib/components/admin/Settings/Documents.svelte (+1 -27)
📝 src/lib/components/admin/Settings/Evaluations/ArenaModelModal.svelte (+4 -33)
📝 src/lib/components/admin/Settings/Images.svelte (+2 -23)
📝 src/lib/components/admin/Settings/Interface/Banners.svelte (+2 -10)
📝 src/lib/components/admin/Settings/Models/ConfigureModelsModal.svelte (+3 -33)
📝 src/lib/components/admin/Settings/Models/ManageModelsModal.svelte (+2 -10)
📝 src/lib/components/admin/Users/Groups/AddGroupModal.svelte (+4 -33)
📝 src/lib/components/admin/Users/Groups/EditGroupModal.svelte (+4 -33)
📝 src/lib/components/admin/Users/UserList/AddUserModal.svelte (+4 -33)
📝 src/lib/components/admin/Users/UserList/EditUserModal.svelte (+2 -10)
📝 src/lib/components/chat/MessageInput/VoiceRecording.svelte (+2 -10)
📝 src/lib/components/chat/Messages/CitationsModal.svelte (+3 -10)

...and 20 more files

📄 Description

Pull Request Checklist

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests to validate the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

  • This pull request refactors modal components by replacing inline SVG declarations for common UI elements (close icon (XMark.svelte & loading spinner (Spinner.svelte) with references to existing, reusable Svelte components. This improves code consistency, maintainability, and reduces redundancy.

Changed

  • Refactored 38 UI components to replace inline SVG definitions for close buttons and loading indicators with imported Svelte components:
    • Modal Components: AddConnectionModal.svelte, AddServerModal.svelte, ChangelogModal.svelte, ImportModal.svelte, FeedbackModal.svelte, LeaderboardModal.svelte, ManageOllamaModal.svelte, ArenaModelModal.svelte, ConfigureModelsModal.svelte, ManageModelsModal.svelte, AddGroupModal.svelte, EditGroupModal.svelte, AddUserModal.svelte, EditUserModal.svelte, CitationsModal.svelte, CodeExecutionModal.svelte, AddMemoryModal.svelte, EditMemoryModal.svelte, ShareChatModal.svelte, ShortcutsModal.svelte, ToolServersModal.svelte, ChannelModal.svelte, AccessControlModal.svelte, ManifestModal.svelte, ValvesModal.svelte.
    • Editor Components: ModelEditor.svelte, PromptEditor.svelte.
    • Common & Admin Components: Audio.svelte (admin), Documents.svelte, Images.svelte (admin), Banners.svelte (admin), VoiceRecording.svelte, RateComment.svelte, Selector.svelte, FileItem.svelte, Image.svelte, ImagePreview.svelte, CreateKnowledgeBase.svelte.
  • Minor updates have occurred within src/lib/components/common/Spinner.svelte and src/lib/components/icons/XMark.svelte themselves to support this standardization.

Removed

  • Removed various inline SVG definitions for icons and spinners.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/15314 **Author:** [@silentoplayz](https://github.com/silentoplayz) **Created:** 6/25/2025 **Status:** ✅ Merged **Merged:** 6/27/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `spinner-and-xmark-icon-components` --- ### 📝 Commits (2) - [`d1e3940`](https://github.com/open-webui/open-webui/commit/d1e3940abdc5f2850cef1bcaf1602bb118523eea) refac: Spinner and XMark components - [`f429dd6`](https://github.com/open-webui/open-webui/commit/f429dd667f44d4ac6c31c69e36f9ffa2201c1981) chore: remove comment ### 📊 Changes **40 files changed** (+115 additions, -778 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/AddConnectionModal.svelte` (+4 -34) 📝 `src/lib/components/AddServerModal.svelte` (+4 -35) 📝 `src/lib/components/ChangelogModal.svelte` (+3 -11) 📝 `src/lib/components/ImportModal.svelte` (+4 -33) 📝 `src/lib/components/admin/Evaluations/FeedbackModal.svelte` (+2 -10) 📝 `src/lib/components/admin/Evaluations/LeaderboardModal.svelte` (+2 -10) 📝 `src/lib/components/admin/Settings/Audio.svelte` (+2 -27) 📝 `src/lib/components/admin/Settings/Connections/ManageOllamaModal.svelte` (+2 -10) 📝 `src/lib/components/admin/Settings/Documents.svelte` (+1 -27) 📝 `src/lib/components/admin/Settings/Evaluations/ArenaModelModal.svelte` (+4 -33) 📝 `src/lib/components/admin/Settings/Images.svelte` (+2 -23) 📝 `src/lib/components/admin/Settings/Interface/Banners.svelte` (+2 -10) 📝 `src/lib/components/admin/Settings/Models/ConfigureModelsModal.svelte` (+3 -33) 📝 `src/lib/components/admin/Settings/Models/ManageModelsModal.svelte` (+2 -10) 📝 `src/lib/components/admin/Users/Groups/AddGroupModal.svelte` (+4 -33) 📝 `src/lib/components/admin/Users/Groups/EditGroupModal.svelte` (+4 -33) 📝 `src/lib/components/admin/Users/UserList/AddUserModal.svelte` (+4 -33) 📝 `src/lib/components/admin/Users/UserList/EditUserModal.svelte` (+2 -10) 📝 `src/lib/components/chat/MessageInput/VoiceRecording.svelte` (+2 -10) 📝 `src/lib/components/chat/Messages/CitationsModal.svelte` (+3 -10) _...and 20 more files_ </details> ### 📄 Description # Pull Request Checklist **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - This pull request refactors modal components by replacing inline SVG declarations for common UI elements (close icon (`XMark.svelte` & loading spinner (`Spinner.svelte`) with references to existing, reusable Svelte components. This improves code consistency, maintainability, and reduces redundancy. ### Changed - Refactored 38 UI components to replace inline SVG definitions for close buttons and loading indicators with imported Svelte components: - **Modal Components:** `AddConnectionModal.svelte`, `AddServerModal.svelte`, `ChangelogModal.svelte`, `ImportModal.svelte`, `FeedbackModal.svelte`, `LeaderboardModal.svelte`, `ManageOllamaModal.svelte`, `ArenaModelModal.svelte`, `ConfigureModelsModal.svelte`, `ManageModelsModal.svelte`, `AddGroupModal.svelte`, `EditGroupModal.svelte`, `AddUserModal.svelte`, `EditUserModal.svelte`, `CitationsModal.svelte`, `CodeExecutionModal.svelte`, `AddMemoryModal.svelte`, `EditMemoryModal.svelte`, `ShareChatModal.svelte`, `ShortcutsModal.svelte`, `ToolServersModal.svelte`, `ChannelModal.svelte`, `AccessControlModal.svelte`, `ManifestModal.svelte`, `ValvesModal.svelte`. - **Editor Components:** `ModelEditor.svelte`, `PromptEditor.svelte`. - **Common & Admin Components:** `Audio.svelte` (admin), `Documents.svelte`, `Images.svelte` (admin), `Banners.svelte` (admin), `VoiceRecording.svelte`, `RateComment.svelte`, `Selector.svelte`, `FileItem.svelte`, `Image.svelte`, `ImagePreview.svelte`, `CreateKnowledgeBase.svelte`. - Minor updates have occurred within `src/lib/components/common/Spinner.svelte` and `src/lib/components/icons/XMark.svelte` themselves to support this standardization. ### Removed - Removed various inline SVG definitions for icons and spinners. ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 05:02:16 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#23790
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?