github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-05-06 10:58:17 -05:00
Code Issues 1.2k Packages Projects Releases 126 Wiki Activity

[PR #15310] [MERGED] chore: Remove MagnifyingGlass icon component and update to use Search icon component #23788

New Issue
Closed
opened 2026-04-20 05:02:09 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 05:02:09 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/15310
Author: @silentoplayz
Created: 6/25/2025
Status: ✅ Merged
Merged: 6/27/2025
Merged by: @tjbck

Base: dev ← Head: icons

📝 Commits (4)

📊 Changes

10 files changed (+21 additions, -91 deletions)

View changed files

📝 src/lib/components/admin/Evaluations/Leaderboard.svelte (+2 -2)
📝 src/lib/components/admin/Users/Groups.svelte (+2 -12)
📝 src/lib/components/admin/Users/Groups/Users.svelte (+2 -12)
📝 src/lib/components/chat/Messages/ResponseMessage/WebSearchResults.svelte (+2 -2)
➖ src/lib/components/icons/MagnifyingGlass.svelte (+0 -19)
📝 src/lib/components/icons/Search.svelte (+5 -6)
📝 src/lib/components/layout/Sidebar.svelte (+2 -2)
📝 src/lib/components/layout/Sidebar/SearchInput.svelte (+2 -12)
📝 src/lib/components/workspace/Knowledge/KnowledgeBase.svelte (+2 -12)
📝 src/lib/components/workspace/Models/Knowledge/Selector.svelte (+2 -12)

📄 Description

Pull Request Checklist

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests to validate the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

  • This pull request standardizes the search icon usage across the application and updates the visual style of the search icon in the icon file itself. It replaces various inline SVG search icons and the MagnifyingGlass component with a newly updated and consistent Search component.

Changed

  • Updated the Search icon component (src/lib/components/icons/Search.svelte) to a new, filled visual style, replacing the previous outlined magnifying glass design.
  • Refactored multiple UI components to consistently use the updated Search icon component, removing redundant inline SVGs and the MagnifyingGlass component:
    • src/lib/components/admin/Evaluations/Leaderboard.svelte
    • src/lib/components/admin/Users/Groups.svelte
    • src/lib/components/admin/Users/Groups/Users.svelte
    • src/lib/components/chat/Messages/ResponseMessage/WebSearchResults.svelte
    • src/lib/components/layout/Sidebar.svelte
    • src/lib/components/layout/Sidebar/SearchInput.svelte
    • src/lib/components/workspace/Knowledge/KnowledgeBase.svelte
    • src/lib/components/workspace/Models/Knowledge/Selector.svelte

Removed

  • Removed the MagnifyingGlass.svelte icon component (src/lib/components/icons/MagnifyingGlass.svelte), as its functionality is now covered by the updated Search.svelte component.

Additional Information

  • This change aims to improve design consistency and reduce redundancy in icon assets.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/15310 **Author:** [@silentoplayz](https://github.com/silentoplayz) **Created:** 6/25/2025 **Status:** ✅ Merged **Merged:** 6/27/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `icons` --- ### 📝 Commits (4) - [`3f865f0`](https://github.com/open-webui/open-webui/commit/3f865f0b66ef0dabf65bbfb198dab551aaebdc98) chore: MagnifyingGlass -> Search - [`88c4f55`](https://github.com/open-webui/open-webui/commit/88c4f55a51f8019c59b24b5c29dce307dc3b8ff1) chore: update - [`dd0e6bf`](https://github.com/open-webui/open-webui/commit/dd0e6bf58f033da0d637713622733e723564797c) remove class="w-5 h-5" /> - [`cf24e39`](https://github.com/open-webui/open-webui/commit/cf24e39404823eb526f3e571d83cb8398e737689) chore: add strokeWidth back ### 📊 Changes **10 files changed** (+21 additions, -91 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/admin/Evaluations/Leaderboard.svelte` (+2 -2) 📝 `src/lib/components/admin/Users/Groups.svelte` (+2 -12) 📝 `src/lib/components/admin/Users/Groups/Users.svelte` (+2 -12) 📝 `src/lib/components/chat/Messages/ResponseMessage/WebSearchResults.svelte` (+2 -2) ➖ `src/lib/components/icons/MagnifyingGlass.svelte` (+0 -19) 📝 `src/lib/components/icons/Search.svelte` (+5 -6) 📝 `src/lib/components/layout/Sidebar.svelte` (+2 -2) 📝 `src/lib/components/layout/Sidebar/SearchInput.svelte` (+2 -12) 📝 `src/lib/components/workspace/Knowledge/KnowledgeBase.svelte` (+2 -12) 📝 `src/lib/components/workspace/Models/Knowledge/Selector.svelte` (+2 -12) </details> ### 📄 Description # Pull Request Checklist **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - This pull request standardizes the search icon usage across the application and updates the visual style of the search icon in the icon file itself. It replaces various inline SVG search icons and the `MagnifyingGlass` component with a newly updated and consistent `Search` component. ### Changed - Updated the `Search` icon component (`src/lib/components/icons/Search.svelte`) to a new, filled visual style, replacing the previous outlined magnifying glass design. - Refactored multiple UI components to consistently use the updated `Search` icon component, removing redundant inline SVGs and the `MagnifyingGlass` component: - `src/lib/components/admin/Evaluations/Leaderboard.svelte` - `src/lib/components/admin/Users/Groups.svelte` - `src/lib/components/admin/Users/Groups/Users.svelte` - `src/lib/components/chat/Messages/ResponseMessage/WebSearchResults.svelte` - `src/lib/components/layout/Sidebar.svelte` - `src/lib/components/layout/Sidebar/SearchInput.svelte` - `src/lib/components/workspace/Knowledge/KnowledgeBase.svelte` - `src/lib/components/workspace/Models/Knowledge/Selector.svelte` ### Removed - Removed the `MagnifyingGlass.svelte` icon component (`src/lib/components/icons/MagnifyingGlass.svelte`), as its functionality is now covered by the updated `Search.svelte` component. --- ### Additional Information - This change aims to improve design consistency and reduce redundancy in icon assets. ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 05:02:09 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#23788
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?