[PR #15091] [CLOSED] refac: open in new tab & draggable/highlight patches #23712

Closed
opened 2026-04-20 04:58:27 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/15091
Author: @silentoplayz
Created: 6/18/2025
Status: Closed

Base: devHead: open-in-new-tab-patches


📝 Commits (6)

  • b462ec2 refac: open in new tab & draggable/highlight patches
  • e467545 fix: href for UserMenu
  • 9bd5c81 refac: open in new tab
  • de5c3b7 fix: attempt at resolving merge conflicts
  • fc385cb Merge branch 'dev' into open-in-new-tab-patches
  • adddc2d fix: bump

📊 Changes

11 files changed (+255 additions, -204 deletions)

View changed files

📝 src/lib/components/admin/Evaluations.svelte (+10 -12)
📝 src/lib/components/admin/Functions.svelte (+15 -2)
📝 src/lib/components/admin/Settings.svelte (+66 -79)
📝 src/lib/components/admin/Users.svelte (+10 -12)
📝 src/lib/components/layout/Sidebar/UserMenu.svelte (+30 -23)
📝 src/lib/components/workspace/Knowledge.svelte (+53 -53)
📝 src/lib/components/workspace/Models.svelte (+12 -5)
📝 src/lib/components/workspace/Prompts.svelte (+9 -1)
📝 src/lib/components/workspace/Tools.svelte (+12 -4)
📝 src/routes/(app)/admin/+layout.svelte (+28 -11)
📝 src/routes/(app)/workspace/+layout.svelte (+10 -2)

📄 Description

Pull Request Checklist

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests to validate the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

  • Fixed drag-and-drop and text highlight behavior for various navigation and interactive elements across workspace pages. This change involved refactoring buttons and divs into standard anchor tags (<a>) to leverage native browser link functionality, ensuring compatibility with "open in new window/tab" features, while also preventing unwanted drag interactions and text selection.

Added

  • Added href attributes to various elements (previously button or div) to enable standard link navigation.
  • Added draggable="false" attribute to all affected <a> tags to prevent unintended drag-and-drop interactions.
  • Added select-none class to most affected <a> tags to prevent unwanted text highlighting/selection.
  • Added target="_blank" attribute for external links to ensure they open in new tabs/windows.

Changed

  • Converted various <button> and <div> elements, previously handling navigation via on:click, into <a> (anchor) elements.
  • Refactored navigation logic from on:click event handlers to standard href attributes for <a> tags, aligning with standard web practices.

Removed

  • Removed on:click event handlers for navigation from the converted elements.

Fixed

  • Resolved unintended drag-and-drop behavior on interactive elements.
  • Corrected unwanted text highlighting/selection on interactive elements.
  • Ensured "open in new window/tab" functionality works correctly for relevant navigation elements.

Additional Information

  • This change ensures that navigation and interactive elements behave more like standard web links, allowing users to open pages in new tabs/windows via common browser gestures (e.g., middle-click, right-click "Open Link in New Tab").
  • The added draggable="false" and select-none attributes specifically address the drag-and-drop and text highlight issues previously experienced with these elements across various workspace components.
  • I have manually tested and compared my modifications in this PR to the initial files before them and this PR provides an overall improvement towards navigation and interaction within the UI.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/15091 **Author:** [@silentoplayz](https://github.com/silentoplayz) **Created:** 6/18/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `open-in-new-tab-patches` --- ### 📝 Commits (6) - [`b462ec2`](https://github.com/open-webui/open-webui/commit/b462ec299305306bfd0430578db4891a4d8e110b) refac: open in new tab & draggable/highlight patches - [`e467545`](https://github.com/open-webui/open-webui/commit/e467545a93fdfe0b07b7be050e6ddb7b44de9451) fix: href for UserMenu - [`9bd5c81`](https://github.com/open-webui/open-webui/commit/9bd5c81e21f7bce4c469eb56bd379afdacfa2e78) refac: open in new tab - [`de5c3b7`](https://github.com/open-webui/open-webui/commit/de5c3b7e7979600af7d21e6d53d9f14ea4285726) fix: attempt at resolving merge conflicts - [`fc385cb`](https://github.com/open-webui/open-webui/commit/fc385cbf38289e80c3c0201743a8f4e65a247bc2) Merge branch 'dev' into open-in-new-tab-patches - [`adddc2d`](https://github.com/open-webui/open-webui/commit/adddc2d6bf3308fab256c9955c33083a54ac5e4e) fix: bump ### 📊 Changes **11 files changed** (+255 additions, -204 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/admin/Evaluations.svelte` (+10 -12) 📝 `src/lib/components/admin/Functions.svelte` (+15 -2) 📝 `src/lib/components/admin/Settings.svelte` (+66 -79) 📝 `src/lib/components/admin/Users.svelte` (+10 -12) 📝 `src/lib/components/layout/Sidebar/UserMenu.svelte` (+30 -23) 📝 `src/lib/components/workspace/Knowledge.svelte` (+53 -53) 📝 `src/lib/components/workspace/Models.svelte` (+12 -5) 📝 `src/lib/components/workspace/Prompts.svelte` (+9 -1) 📝 `src/lib/components/workspace/Tools.svelte` (+12 -4) 📝 `src/routes/(app)/admin/+layout.svelte` (+28 -11) 📝 `src/routes/(app)/workspace/+layout.svelte` (+10 -2) </details> ### 📄 Description # Pull Request Checklist **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Fixed drag-and-drop and text highlight behavior for various navigation and interactive elements across workspace pages. This change involved refactoring buttons and divs into standard anchor tags (`<a>`) to leverage native browser link functionality, ensuring compatibility with "open in new window/tab" features, while also preventing unwanted drag interactions and text selection. ### Added - Added `href` attributes to various elements (previously `button` or `div`) to enable standard link navigation. - Added `draggable="false"` attribute to all affected `<a>` tags to prevent unintended drag-and-drop interactions. - Added `select-none` class to most affected `<a>` tags to prevent unwanted text highlighting/selection. - Added `target="_blank"` attribute for external links to ensure they open in new tabs/windows. ### Changed - Converted various `<button>` and `<div>` elements, previously handling navigation via `on:click`, into `<a>` (anchor) elements. - Refactored navigation logic from `on:click` event handlers to standard `href` attributes for `<a>` tags, aligning with standard web practices. ### Removed - Removed `on:click` event handlers for navigation from the converted elements. ### Fixed - Resolved unintended drag-and-drop behavior on interactive elements. - Corrected unwanted text highlighting/selection on interactive elements. - Ensured "open in new window/tab" functionality works correctly for relevant navigation elements. --- ### Additional Information - This change ensures that navigation and interactive elements behave more like standard web links, allowing users to open pages in new tabs/windows via common browser gestures (e.g., middle-click, right-click "Open Link in New Tab"). - The added `draggable="false"` and `select-none` attributes specifically address the drag-and-drop and text highlight issues previously experienced with these elements across various workspace components. - I have manually tested and compared my modifications in this PR to the initial files before them and this PR provides an overall improvement towards navigation and interaction within the UI. ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 04:58:27 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#23712