[PR #14774] [MERGED] fix: Store and load code interpreter generated images from a central location (DB and/or cloud storage) #23587

New Issue

GiteaMirror · 2026-04-20T04:54:46-05:00

GiteaMirror commented

2026-04-20 04:54:46 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/14774
Author: @rragundez
Created: 6/8/2025
Status: ✅ Merged
Merged: 6/8/2025
Merged by: @tjbck

Base: dev ← Head: images-from-db

📝 Commits (2)

168997a Return tuple consistently and strip potential left string
41e28a9 Use standardized procedure to save and load images

📊 Changes

2 files changed (+31 additions, -43 deletions)

View changed files

📝 backend/open_webui/routers/images.py (+2 -2)
📝 backend/open_webui/utils/middleware.py (+29 -41)

📄 Description

This PR introduces the standardized way of saving and loading images to the images generated by code interpreter. This is the same logic that applied to images generated by a image generation model, for example here: 53764fe648/backend/open_webui/routers/images.py (L530)

This will also solve 2 current issues:

Images will now be available in a multiple replica environment since they are saved in a centralized common storage (DB)
Images will only be available to users that create them, similar to the images generated by an image generation model.

Discussion on #14649

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

[Concisely describe the changes made in this pull request, including any relevant motivation and impact (e.g., fixing a bug, adding a feature, or improving performance)]

Added

[List any new features, functionalities, or additions]

Changed

[List any changes, updates, refactorings, or optimizations]

Deprecated

[List any deprecated functionality or features that have been removed]

Removed

[List any removed features, files, or functionalities]

Fixed

[List any fixes, corrections, or bug fixes]

Security

[List any new or updated security-related changes, including vulnerability fixes]

Breaking Changes

BREAKING CHANGE: [List any breaking changes affecting compatibility or functionality]

Additional Information

[Insert any additional context, notes, or explanations for the changes]
- [Reference any related issues, commits, or other relevant information]

Screenshots or Videos

[Attach any relevant screenshots or videos demonstrating the changes]

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/14774 **Author:** [@rragundez](https://github.com/rragundez) **Created:** 6/8/2025 **Status:** ✅ Merged **Merged:** 6/8/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `images-from-db` --- ### 📝 Commits (2) - [`168997a`](https://github.com/open-webui/open-webui/commit/168997a58e11a76a9c870fe93c611bf61a2c43f7) Return tuple consistently and strip potential left string - [`41e28a9`](https://github.com/open-webui/open-webui/commit/41e28a9f6f22d84e71d88731a7e2bc8f68b46331) Use standardized procedure to save and load images ### 📊 Changes **2 files changed** (+31 additions, -43 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/images.py` (+2 -2) 📝 `backend/open_webui/utils/middleware.py` (+29 -41) </details> ### 📄 Description This PR introduces the standardized way of saving and loading images to the images generated by code interpreter. This is the same logic that applied to images generated by a image generation model, for example here: https://github.com/open-webui/open-webui/blob/53764fe64884da147359e54ed6d9607fe57f1600/backend/open_webui/routers/images.py#L530 This will also solve 2 current issues: - Images will now be available in a multiple replica environment since they are saved in a centralized common storage (DB) - Images will only be available to users that create them, similar to the images generated by an image generation model. Discussion on #14649 **Before submitting, make sure you've checked the following:** - [ ] **Target branch:** Please verify that the pull request targets the `dev` branch. - [ ] **Description:** Provide a concise description of the changes made in this pull request. - [ ] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ ] **Testing:** Have you written and run sufficient tests to validate the changes? - [ ] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [ ] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - [Concisely describe the changes made in this pull request, including any relevant motivation and impact (e.g., fixing a bug, adding a feature, or improving performance)] ### Added - [List any new features, functionalities, or additions] ### Changed - [List any changes, updates, refactorings, or optimizations] ### Deprecated - [List any deprecated functionality or features that have been removed] ### Removed - [List any removed features, files, or functionalities] ### Fixed - [List any fixes, corrections, or bug fixes] ### Security - [List any new or updated security-related changes, including vulnerability fixes] ### Breaking Changes - **BREAKING CHANGE**: [List any breaking changes affecting compatibility or functionality] --- ### Additional Information - [Insert any additional context, notes, or explanations for the changes] - [Reference any related issues, commits, or other relevant information] ### Screenshots or Videos - [Attach any relevant screenshots or videos demonstrating the changes] ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-20 04:54:46 -05:00

GiteaMirror closed this issue

2026-04-20 04:54:47 -05:00

GiteaMirror referenced this issue

2026-04-20 06:58:06 -05:00

[PR #23587] [CLOSED] fix: pass db session to filter_allowed_access_grants in update_note_access_by_id #27267

GiteaMirror referenced this issue

2026-04-25 09:44:57 -05:00

[GH-ISSUE #23586] bug: missing db=db parameter in filter_allowed_access_grants call in update_note_access_by_id #35549

GiteaMirror referenced this issue

2026-04-25 14:40:07 -05:00

[PR #23587] [CLOSED] fix: pass db session to filter_allowed_access_grants in update_note_access_by_id #42897