github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-05-06 19:08:59 -05:00
Code Issues 1.3k Packages Projects Releases 126 Wiki Activity

[PR #14772] [MERGED] Fix: Ensure Consistent LDAP Settings Save #23586

New Issue
Closed
opened 2026-04-20 04:54:45 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 04:54:45 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/14772
Author: @silentoplayz
Created: 6/8/2025
Status: ✅ Merged
Merged: 6/8/2025
Merged by: @tjbck

Base: dev ← Head: fix-save-for-LDAP

📝 Commits (2)

  • 67e930e Fix: Ensure Consistent LDAP Settings Save
  • a6c7ddc fix: Hidden delete button for playground chat messages

📊 Changes

2 files changed (+3 additions, -7 deletions)

View changed files

📝 src/lib/components/admin/Settings/General.svelte (+2 -6)
📝 src/lib/components/playground/Chat/Message.svelte (+1 -1)

📄 Description

Pull Request Checklist

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests to validate the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

  • Fixed an inconsistency in how the LDAP enable/disable setting was saved. Previously, toggling the LDAP switch would immediately update the configuration, whereas all other settings required an explicit "Save" action via the form submission button. This change ensures that the LDAP setting is now saved consistently with the other general settings when the "Save" button is clicked.

Changed

  • The saving mechanism for the ENABLE_LDAP setting on the General admin page was changed from an immediate on:change event on the switch component to be included in the main form submission via the updateHandler.

Removed

  • The on:change event handler from the Switch component associated with ENABLE_LDAP.

Fixed

  • Fixed inconsistent save behavior for the LDAP enable/disable switch, aligning it with the general settings save flow.

Additional Information

  • This change improves the user experience by providing a unified and predictable save flow for all settings on the General configuration page.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/14772 **Author:** [@silentoplayz](https://github.com/silentoplayz) **Created:** 6/8/2025 **Status:** ✅ Merged **Merged:** 6/8/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix-save-for-LDAP` --- ### 📝 Commits (2) - [`67e930e`](https://github.com/open-webui/open-webui/commit/67e930e1d292647a9e121113d4b6605b39db49a6) Fix: Ensure Consistent LDAP Settings Save - [`a6c7ddc`](https://github.com/open-webui/open-webui/commit/a6c7ddcb28c6559b7f4cbacb1d1090e50076e4e3) fix: Hidden delete button for playground chat messages ### 📊 Changes **2 files changed** (+3 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/admin/Settings/General.svelte` (+2 -6) 📝 `src/lib/components/playground/Chat/Message.svelte` (+1 -1) </details> ### 📄 Description # Pull Request Checklist **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Fixed an inconsistency in how the LDAP enable/disable setting was saved. Previously, toggling the LDAP switch would immediately update the configuration, whereas all other settings required an explicit "Save" action via the form submission button. This change ensures that the LDAP setting is now saved consistently with the other general settings when the "Save" button is clicked. ### Changed - The saving mechanism for the `ENABLE_LDAP` setting on the General admin page was changed from an immediate `on:change` event on the switch component to be included in the main form submission via the `updateHandler`. ### Removed - The `on:change` event handler from the `Switch` component associated with `ENABLE_LDAP`. ### Fixed - Fixed inconsistent save behavior for the LDAP enable/disable switch, aligning it with the general settings save flow. --- ### Additional Information - This change improves the user experience by providing a unified and predictable save flow for all settings on the General configuration page. ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 04:54:45 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#23586
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?