[PR #14618] [CLOSED] feat: edit?id= URL functionality to the Admin Settings "Models" edit page #23524

New Issue

GiteaMirror · 2026-04-20T04:52:43-05:00

GiteaMirror commented

2026-04-20 04:52:43 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/14618
Author: @silentoplayz
Created: 6/3/2025
Status: ❌ Closed

Base: dev ← Head: admin-models-edit-id

📝 Commits (1)

1e05852 feat: edit?id= for admin models edit page

📊 Changes

2 files changed (+32 additions, -5 deletions)

View changed files

📝 src/lib/components/admin/Settings/Models.svelte (+27 -5)
➕ src/routes/(app)/admin/settings/models/edit/+page.svelte (+5 -0)

📄 Description

Pull Request Checklist

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Added edit?id= URL functionality to the Admin Settings "Models" edit page, enabling direct access to a specific model's edit interface via URL query parameters. This provides a consistent editing experience with workspace models and improves navigability.

Added

src/routes/(app)/admin/settings/models/edit/+page.svelte: New file to define the /admin/settings/models/edit route, which renders the Models.svelte component.

Changed

src/lib/components/admin/Settings/Models.svelte:
- Added import { page } from '$app/stores'; and import { goto } from '$app/navigation';.
- Introduced a reactive block ($: { ... }) to dynamically set selectedModelId based on the id query parameter when the URL path is /admin/settings/models/edit. This ensures the model editor is displayed when accessing the URL directly.
- Modified the on:click handlers for model list items (both the main button and the edit icon) to navigate to /admin/settings/models/edit?id=${model.id}.
- Updated the onSubmit and onBack handlers of the ModelEditor to navigate back to /admin/settings/models, clearing the id query parameter and returning to the model list view.
- Initialized filteredModels with an empty array (let filteredModels = [];) to prevent ReferenceError: assignment to undeclared variable.

Fixed

Ensured that the ModelEditor correctly displays a specific model when accessed via a URL like /admin/settings/models/edit?id=your-model-id.
Handled cases where an invalid or missing id in the URL for the edit page redirects gracefully back to the model list.

Additional Information

This change brings consistency to how model editing is handled across the application, using URL-based state management for admin model editing.
It allows for direct linking to specific model configurations within the admin panel.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/14618 **Author:** [@silentoplayz](https://github.com/silentoplayz) **Created:** 6/3/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `admin-models-edit-id` --- ### 📝 Commits (1) - [`1e05852`](https://github.com/open-webui/open-webui/commit/1e05852cdb84c09893ba6a9dd6c7099744fb39e3) feat: edit?id= for admin models edit page ### 📊 Changes **2 files changed** (+32 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/admin/Settings/Models.svelte` (+27 -5) ➕ `src/routes/(app)/admin/settings/models/edit/+page.svelte` (+5 -0) </details> ### 📄 Description # Pull Request Checklist **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Added `edit?id=` URL functionality to the Admin Settings "Models" edit page, enabling direct access to a specific model's edit interface via URL query parameters. This provides a consistent editing experience with workspace models and improves navigability. ### Added - `src/routes/(app)/admin/settings/models/edit/+page.svelte`: New file to define the `/admin/settings/models/edit` route, which renders the `Models.svelte` component. ### Changed - `src/lib/components/admin/Settings/Models.svelte`: - Added `import { page } from '$app/stores';` and `import { goto } from '$app/navigation';`. - Introduced a reactive block (`$: { ... }`) to dynamically set `selectedModelId` based on the `id` query parameter when the URL path is `/admin/settings/models/edit`. This ensures the model editor is displayed when accessing the URL directly. - Modified the `on:click` handlers for model list items (both the main button and the edit icon) to navigate to `/admin/settings/models/edit?id=${model.id}`. - Updated the `onSubmit` and `onBack` handlers of the `ModelEditor` to navigate back to `/admin/settings/models`, clearing the `id` query parameter and returning to the model list view. - Initialized `filteredModels` with an empty array (`let filteredModels = [];`) to prevent `ReferenceError: assignment to undeclared variable`. ### Fixed - Ensured that the `ModelEditor` correctly displays a specific model when accessed via a URL like `/admin/settings/models/edit?id=your-model-id`. - Handled cases where an invalid or missing `id` in the URL for the edit page redirects gracefully back to the model list. --- ### Additional Information - This change brings consistency to how model editing is handled across the application, using URL-based state management for admin model editing. - It allows for direct linking to specific model configurations within the admin panel. ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-20 04:52:43 -05:00

GiteaMirror closed this issue

2026-04-20 04:52:44 -05:00

GiteaMirror referenced this issue

2026-04-20 06:57:02 -05:00

[PR #23524] [CLOSED] fix: handle ChatGPT exports with folder/project entries #27237

GiteaMirror referenced this issue

2026-04-20 06:57:10 -05:00

[PR #23531] fix: handle ChatGPT exports containing folder/project metadata entries #27242

GiteaMirror referenced this issue

2026-04-25 14:38:44 -05:00

[PR #23524] [CLOSED] fix: handle ChatGPT exports with folder/project entries #42867