[PR #14362] [MERGED] Fix/chat engagement critical #23450

New Issue

GiteaMirror · 2026-04-20T04:49:57-05:00

GiteaMirror commented

2026-04-20 04:49:57 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/14362
Author: @PVBLIC-F
Created: 5/26/2025
Status: ✅ Merged
Merged: 5/26/2025
Merged by: @tjbck

Base: dev ← Head: fix/chat-engagement-critical

📝 Commits (2)

d414662 fix: resolve chat engagement TypeError - Fix get_message_list() to return [] instead of None - Fix middleware to use correct metadata message_id - Add safe fallback for missing role field - Ensure assistant messages include role field
256034e Update misc.py

📊 Changes

2 files changed (+9 additions, -4 deletions)

View changed files

📝 backend/open_webui/utils/middleware.py (+3 -2)
📝 backend/open_webui/utils/misc.py (+6 -2)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Laying the ground work for an upgraded chat experience.

Added

[List any new features, functionalities, or additions]

Changed

[List any changes, updates, refactorings, or optimizations]

Deprecated

[List any deprecated functionality or features that have been removed]

Removed

[List any removed features, files, or functionalities]

Fixed

-The update resolved these specific issues:

TypeError: 'NoneType' object is not iterable
Root cause: get_message_list() returned None instead of []
Fix: Now returns empty list [] for safe iteration

KeyError: 'role' in background tasks
Root cause: Messages missing required "role" field
Fix: Added safe fallback message.get("role", "assistant")

message_id=None warnings
Root cause: Wrong metadata access in middleware
Fix: Use correct metadata["message_id"] instead of message.get("id")

Security

[List any new or updated security-related changes, including vulnerability fixes]

Breaking Changes

BREAKING CHANGE: [List any breaking changes affecting compatibility or functionality]

Additional Information

[Insert any additional context, notes, or explanations for the changes]
- [Reference any related issues, commits, or other relevant information]

Screenshots or Videos

[Attach any relevant screenshots or videos demonstrating the changes]

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/14362 **Author:** [@PVBLIC-F](https://github.com/PVBLIC-F) **Created:** 5/26/2025 **Status:** ✅ Merged **Merged:** 5/26/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/chat-engagement-critical` --- ### 📝 Commits (2) - [`d414662`](https://github.com/open-webui/open-webui/commit/d414662d236f2694e9b15381fbecd2bd9968a744) fix: resolve chat engagement TypeError - Fix get_message_list() to return [] instead of None - Fix middleware to use correct metadata message_id - Add safe fallback for missing role field - Ensure assistant messages include role field - [`256034e`](https://github.com/open-webui/open-webui/commit/256034e28505eb77e83a5eca05c057675f43d3b9) Update misc.py ### 📊 Changes **2 files changed** (+9 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/utils/middleware.py` (+3 -2) 📝 `backend/open_webui/utils/misc.py` (+6 -2) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [ ] **Target branch:** Please verify that the pull request targets the `dev` branch. - [ ] **Description:** Provide a concise description of the changes made in this pull request. - [ ] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ ] **Testing:** Have you written and run sufficient tests to validate the changes? - [ ] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [ ] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Laying the ground work for an upgraded chat experience. ### Added - [List any new features, functionalities, or additions] ### Changed - [List any changes, updates, refactorings, or optimizations] ### Deprecated - [List any deprecated functionality or features that have been removed] ### Removed - [List any removed features, files, or functionalities] ### Fixed -The update resolved these specific issues: TypeError: 'NoneType' object is not iterable Root cause: get_message_list() returned None instead of [] Fix: Now returns empty list [] for safe iteration KeyError: 'role' in background tasks Root cause: Messages missing required "role" field Fix: Added safe fallback message.get("role", "assistant") message_id=None warnings Root cause: Wrong metadata access in middleware Fix: Use correct metadata["message_id"] instead of message.get("id") ### Security - [List any new or updated security-related changes, including vulnerability fixes] ### Breaking Changes - **BREAKING CHANGE**: [List any breaking changes affecting compatibility or functionality] --- ### Additional Information - [Insert any additional context, notes, or explanations for the changes] - [Reference any related issues, commits, or other relevant information] ### Screenshots or Videos - [Attach any relevant screenshots or videos demonstrating the changes] ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-20 04:49:57 -05:00

GiteaMirror closed this issue

2026-04-20 04:49:58 -05:00

GiteaMirror referenced this issue

2026-04-25 09:43:31 -05:00

[GH-ISSUE #23450] issue: OneDrive Personal Integration broken - redirect_uri contains dynamic chat ID #35516

GiteaMirror referenced this issue

2026-05-05 23:38:24 -05:00

[GH-ISSUE #23450] issue: OneDrive Personal Integration broken - redirect_uri contains dynamic chat ID #58653

Sign in to join this conversation.