[PR #14100] [CLOSED] fix: Setting userContext for Continue Response action #23386

New Issue

GiteaMirror · 2026-04-20T04:47:16-05:00

GiteaMirror commented

2026-04-20 04:47:16 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/14100
Author: @sanvyruz
Created: 5/20/2025
Status: ❌ Closed

Base: dev ← Head: continue-resp-fix

📝 Commits (2)

6ed0f55 Fix userContext update for continueResponse
3ae17ec Fix DOM update

📊 Changes

1 file changed (+34 additions, -23 deletions)

View changed files

📝 src/lib/components/chat/Chat.svelte (+34 -23)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Fixed the missing userContext assignment for 'Continue Response' button action

Changed

Refactored the userContext updating logic in sendPrompt into separate method addUserContext
Reuse the addUserContext within continueResponse

Fixed

Fixing the issue described in https://github.com/open-webui/open-webui/discussions/13828
In summary: For regenerateResponse action, sendPrompt basically gets the userContext by querying memory if enabled, adding it to the response and then calling sendPromptSocket. Idea is to do something similar for continueResponse before calling sendPromptSocket.

Additional Information

addUserContext also needs to invoke tick for DOM updates.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/14100 **Author:** [@sanvyruz](https://github.com/sanvyruz) **Created:** 5/20/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `continue-resp-fix` --- ### 📝 Commits (2) - [`6ed0f55`](https://github.com/open-webui/open-webui/commit/6ed0f5547bd95143594b207a2437320e6a940f9d) Fix userContext update for continueResponse - [`3ae17ec`](https://github.com/open-webui/open-webui/commit/3ae17ec9ca05389fb3b00c410f3008ef8fe8d6c6) Fix DOM update ### 📊 Changes **1 file changed** (+34 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/chat/Chat.svelte` (+34 -23) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Fixed the missing userContext assignment for 'Continue Response' button action ### Changed - Refactored the userContext updating logic in `sendPrompt` into separate method `addUserContext` - Reuse the `addUserContext` within `continueResponse` ### Fixed - Fixing the issue described in https://github.com/open-webui/open-webui/discussions/13828 In summary: For `regenerateResponse` action, `sendPrompt` basically gets the userContext by querying memory if enabled, adding it to the response and then calling `sendPromptSocket`. Idea is to do something similar for `continueResponse` before calling `sendPromptSocket`. --- ### Additional Information - `addUserContext` also needs to invoke tick for DOM updates. ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-20 04:47:16 -05:00

GiteaMirror closed this issue

2026-04-20 04:47:17 -05:00

GiteaMirror referenced this issue

2026-04-20 06:55:14 -05:00

[PR #23386] [CLOSED] fix: query prompt tags by JSON elements #27176

GiteaMirror referenced this issue

2026-04-25 14:36:29 -05:00

[PR #23386] [CLOSED] fix: query prompt tags by JSON elements #42806

GiteaMirror referenced this issue

2026-04-30 02:51:07 -05:00

[PR #23386] [CLOSED] fix: query prompt tags by JSON elements #50224