[PR #14049] [MERGED] fix: web search optional fields #23369

New Issue

GiteaMirror · 2026-04-20T04:46:17-05:00

GiteaMirror commented

2026-04-20 04:46:17 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/14049
Author: @mjmendo
Created: 5/19/2025
Status: ✅ Merged
Merged: 5/20/2025
Merged by: @tjbck

Base: dev ← Head: web_search_optional_fields

📝 Commits (2)

d6ad96a fix: use get method for title and snippet in search results
897727c Merge branch 'open-webui:main' into web_search_optional_fields

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 backend/open_webui/retrieval/web/searchapi.py (+1 -1)
📝 backend/open_webui/retrieval/web/serpapi.py (+1 -1)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

When serpapi was introduced, the snippet field was not treated as optional. The searchapi has the same problem. All the other search methods comply.

This PR adds the null-check for the snippet and title fields in the search results.

Changed

null-check for the snippet and title fields in the search results for searchapi and serpapi

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/14049 **Author:** [@mjmendo](https://github.com/mjmendo) **Created:** 5/19/2025 **Status:** ✅ Merged **Merged:** 5/20/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `web_search_optional_fields` --- ### 📝 Commits (2) - [`d6ad96a`](https://github.com/open-webui/open-webui/commit/d6ad96affbb664658d5287fb93d7b2d8f55200fa) fix: use get method for title and snippet in search results - [`897727c`](https://github.com/open-webui/open-webui/commit/897727c7ebc262b2e26774adfbd2e4f99d464c4d) Merge branch 'open-webui:main' into web_search_optional_fields ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/retrieval/web/searchapi.py` (+1 -1) 📝 `backend/open_webui/retrieval/web/serpapi.py` (+1 -1) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ ] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description When serpapi was [introduced](https://github.com/open-webui/open-webui/pull/9980/files), the snippet field was not treated as optional. The searchapi has the same problem. All the other search methods comply. This PR adds the null-check for the snippet and title fields in the search results. ### Changed - null-check for the snippet and title fields in the search results for `searchapi` and `serpapi` ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-20 04:46:17 -05:00

GiteaMirror closed this issue

2026-04-20 04:46:18 -05:00

GiteaMirror referenced this issue

2026-04-20 06:54:56 -05:00

[PR #23369] [CLOSED] fix(ui): keep chat controls state tab-scoped #27169

GiteaMirror referenced this issue

2026-04-25 14:36:14 -05:00

[PR #23369] [CLOSED] fix(ui): keep chat controls state tab-scoped #42799

GiteaMirror referenced this issue

2026-04-30 02:50:40 -05:00

[PR #23369] [CLOSED] fix(ui): keep chat controls state tab-scoped #50217