github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-05-11 00:13:40 -05:00
Code Issues 1.3k Packages Projects Releases 126 Wiki Activity

[PR #13852] [MERGED] feat: Add option to disable certificate validation for LDAP certificates. #23311

New Issue
Closed
opened 2026-04-20 04:44:52 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 04:44:52 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/13852
Author: @hgaiser
Created: 5/13/2025
Status: ✅ Merged
Merged: 5/14/2025
Merged by: @tjbck

Base: dev ← Head: self-signed-cert

📝 Commits (1)

  • f63e76e Add option to disable certificate validation.

📊 Changes

4 files changed (+26 additions, -2 deletions)

View changed files

📝 backend/open_webui/config.py (+6 -0)
📝 backend/open_webui/main.py (+2 -0)
📝 backend/open_webui/routers/auths.py (+11 -2)
📝 src/lib/components/admin/Settings/General.svelte (+7 -0)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests to validate the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

This PR adds an option to disable LDAP certificate validation, which is useful when using self-signed certificates. Apologies for not opening a discussion first. I saw the notification only after creating the PR (I searched for a CONTRIBUTING.md and didn't find any, maybe that should also be added instead?).

I tested these changes locally and they appear to work as intended.

Added

  • Toggle to disable LDAP certificate validation.

Additional Information

  • I did not use i18n for the translations. What is the correct approach for this ?
  • I'm not sure what the right CSS classes are to fit the style ?

Screenshots or Videos

Screenshot 2025-05-13 at 17-50-14 Admin Panel • Open WebUI

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/13852 **Author:** [@hgaiser](https://github.com/hgaiser) **Created:** 5/13/2025 **Status:** ✅ Merged **Merged:** 5/14/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `self-signed-cert` --- ### 📝 Commits (1) - [`f63e76e`](https://github.com/open-webui/open-webui/commit/f63e76e653000d682b1f5568255ee5171b82e830) Add option to disable certificate validation. ### 📊 Changes **4 files changed** (+26 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/config.py` (+6 -0) 📝 `backend/open_webui/main.py` (+2 -0) 📝 `backend/open_webui/routers/auths.py` (+11 -2) 📝 `src/lib/components/admin/Settings/General.svelte` (+7 -0) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ ] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description This PR adds an option to disable LDAP certificate validation, which is useful when using self-signed certificates. Apologies for not opening a discussion first. I saw the notification only after creating the PR (I searched for a `CONTRIBUTING.md` and didn't find any, maybe that should also be added instead?). I tested these changes locally and they appear to work as intended. ### Added - Toggle to disable LDAP certificate validation. --- ### Additional Information - I did not use `i18n` for the translations. What is the correct approach for this ? - I'm not sure what the right CSS classes are to fit the style ? ### Screenshots or Videos ![Screenshot 2025-05-13 at 17-50-14 Admin Panel • Open WebUI](https://github.com/user-attachments/assets/51f859c9-fbab-4c0e-ac29-c8261696bf29) ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 04:44:52 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#23311
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?