[PR #13631] [CLOSED] fix: Detect Cloudflare R2 endpoint and skip object tagging. Merge S3 upload and tagging operations for better permissions handling. #23250

New Issue

GiteaMirror · 2026-04-20T04:43:13-05:00

GiteaMirror commented

2026-04-20 04:43:13 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/13631
Author: @suleimanelkhoury
Created: 5/7/2025
Status: ❌ Closed

Base: dev ← Head: r2-s3-tagging

📝 Commits (2)

a3bb7df Merge pull request #13530 from open-webui/dev
bf74107 Detect Cloudflare R2 endpoint and skip its object tagging. Merge S3 upload and object tagging in one operation.

📊 Changes

1 file changed (+15 additions, -8 deletions)

View changed files

📝 backend/open_webui/storage/provider.py (+15 -8)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

This pull request adds automatic detection of Cloudflare R2 based on the S3 endpoint URL. When R2 is detected, object tagging operations are skipped during file uploads (PutObjectTagging and tagging headers are omitted) to prevent ��NotImplemented” errors, as Cloudflare R2 does not currently support S3 object tags. It also merges both S3 upload and tagging operations into one operation for better permissions management.

Added

R2 endpoint detection (self.is_r2) in storage provider.
Conditional logic to skip object tagging with Cloudflare R2.

Changed

Merged both S3 upload and tagging operations into one operation for better S3 guidelines.

Deprecated

[List any deprecated functionality or features that have been removed]

Removed

[List any removed features, files, or functionalities]

Fixed

Prevented S3 API errors caused by unsupported tagging operations on R2.
Prevented S3 Permissions error by havinf one operation for upload and tagging instead of two.

Security

S3 User needs to be granted less Permissions to upload files, leading for better permission management.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/13631 **Author:** [@suleimanelkhoury](https://github.com/suleimanelkhoury) **Created:** 5/7/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `r2-s3-tagging` --- ### 📝 Commits (2) - [`a3bb7df`](https://github.com/open-webui/open-webui/commit/a3bb7df61058e690a76cebb7681bd5390e77d226) Merge pull request #13530 from open-webui/dev - [`bf74107`](https://github.com/open-webui/open-webui/commit/bf7410758408f0b275bfb8a1e03bc657764b67c9) Detect Cloudflare R2 endpoint and skip its object tagging. Merge S3 upload and object tagging in one operation. ### 📊 Changes **1 file changed** (+15 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/storage/provider.py` (+15 -8) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - This pull request adds automatic detection of Cloudflare R2 based on the S3 endpoint URL. When R2 is detected, object tagging operations are skipped during file uploads (PutObjectTagging and tagging headers are omitted) to prevent ��NotImplemented” errors, as Cloudflare R2 does not currently support S3 object tags. It also merges both S3 upload and tagging operations into one operation for better permissions management. ### Added - R2 endpoint detection (self.is_r2) in storage provider. - Conditional logic to skip object tagging with Cloudflare R2. ### Changed - Merged both S3 upload and tagging operations into one operation for better S3 guidelines. ### Deprecated - [List any deprecated functionality or features that have been removed] ### Removed - [List any removed features, files, or functionalities] ### Fixed - Prevented S3 API errors caused by unsupported tagging operations on R2. - Prevented S3 Permissions error by havinf one operation for upload and tagging instead of two. ### Security - S3 User needs to be granted less Permissions to upload files, leading for better permission management. --- ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-20 04:43:13 -05:00

GiteaMirror closed this issue

2026-04-20 04:43:13 -05:00

GiteaMirror referenced this issue

2026-04-20 06:52:36 -05:00

[PR #23251] [CLOSED] fix: remove undefined cookie_expires from oauth_session_id set_cookie #27102

GiteaMirror referenced this issue

2026-04-25 09:40:14 -05:00

[GH-ISSUE #23250] issue: oauth_session_id cookie never set due to undefined cookie_expires variable #35460

GiteaMirror referenced this issue

2026-04-25 14:33:06 -05:00

[PR #23251] [CLOSED] fix: remove undefined cookie_expires from oauth_session_id set_cookie #42732