[PR #13313] [CLOSED] fix(auth): handle missing 'exp' in token to avoid TypeError #23152

New Issue

GiteaMirror · 2026-04-20T04:40:08-05:00

GiteaMirror commented

2026-04-20 04:40:08 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/13313
Author: @athoik
Created: 4/29/2025
Status: ❌ Closed

Base: dev ← Head: dev

📝 Commits (1)

7036ec3 fix(auth): handle missing 'exp' in token to avoid TypeError

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 backend/open_webui/routers/auths.py (+1 -1)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Previously, the session validation logic assumed the 'exp' field was always present in the decoded JWT. If it was missing, this led to a TypeError when comparing int(time.time()) > expires_at.

This patch adds a check to ensure 'expires_at' is not None before the comparison, preventing the runtime error.

Fixes crash observed in commit 45ad6776de.

Added

Changed

Deprecated

Removed

Fixed

Fixes crash observed in commit 45ad6776de.

Security

Breaking Changes

BREAKING CHANGE: none

Additional Information

Screenshots or Videos

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the CONTRIBUTOR_LICENSE_AGREEMENT, and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/13313 **Author:** [@athoik](https://github.com/athoik) **Created:** 4/29/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `dev` --- ### 📝 Commits (1) - [`7036ec3`](https://github.com/open-webui/open-webui/commit/7036ec3f4f09c33c65d72905928a94bb01c9663c) fix(auth): handle missing 'exp' in token to avoid TypeError ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/auths.py` (+1 -1) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description Previously, the session validation logic assumed the 'exp' field was always present in the decoded JWT. If it was missing, this led to a TypeError when comparing `int(time.time()) > expires_at`. This patch adds a check to ensure 'expires_at' is not None before the comparison, preventing the runtime error. Fixes crash observed in commit 45ad6776def41b2ff806117e041b35c2e236f9f5. ### Added ### Changed ### Deprecated ### Removed ### Fixed Fixes crash observed in commit 45ad6776def41b2ff806117e041b35c2e236f9f5. ### Security ### Breaking Changes - **BREAKING CHANGE**: none --- ### Additional Information ### Screenshots or Videos ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [CONTRIBUTOR_LICENSE_AGREEMENT](CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-20 04:40:08 -05:00

GiteaMirror closed this issue

2026-04-20 04:40:08 -05:00

GiteaMirror referenced this issue

2026-04-25 09:38:18 -05:00

[GH-ISSUE #23152] issue: Follow Ups corrupt usage statistic in chat_message table #35429

GiteaMirror referenced this issue

2026-05-05 23:26:48 -05:00

[GH-ISSUE #23152] issue: Follow Ups corrupt usage statistic in chat_message table #58566

Sign in to join this conversation.