[PR #12604] [MERGED] **fix** improve stack trace of duckduckgo exception #22986

Closed
opened 2026-04-20 04:33:07 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/12604
Author: @maurerle
Created: 4/8/2025
Status: Merged
Merged: 4/8/2025
Merged by: @tjbck

Base: devHead: ddg_improve_stacktrace


📝 Commits (2)

  • 337c7ca improve stack trace of duckduckgo exception
  • 760ea3f duckduckgo: backend api has been deprecated since december

📊 Changes

3 files changed (+10 additions, -10 deletions)

View changed files

📝 backend/open_webui/retrieval/web/duckduckgo.py (+8 -8)
📝 backend/requirements.txt (+1 -1)
📝 pyproject.toml (+1 -1)

📄 Description

Pull Request Checklist

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests to validate the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?

Changelog Entry

Description

On ratelimiting, it is not easily shown what goes wrong, as one receives the full stack trace as seen here:
https://github.com/open-webui/open-webui/discussions/11503

This should be improved by catching the RatelimitException and only logging an error for this.
We could improve this as well by suggesting to reduce the concurrent requests..?

Fixed

Further fixes include


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/12604 **Author:** [@maurerle](https://github.com/maurerle) **Created:** 4/8/2025 **Status:** ✅ Merged **Merged:** 4/8/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `ddg_improve_stacktrace` --- ### 📝 Commits (2) - [`337c7ca`](https://github.com/open-webui/open-webui/commit/337c7caafa0225badaaedd361ec323b63f75734a) improve stack trace of duckduckgo exception - [`760ea3f`](https://github.com/open-webui/open-webui/commit/760ea3f4afbbaa4f2046dc53aa9ea3fd2f784c53) duckduckgo: backend api has been deprecated since december ### 📊 Changes **3 files changed** (+10 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/retrieval/web/duckduckgo.py` (+8 -8) 📝 `backend/requirements.txt` (+1 -1) 📝 `pyproject.toml` (+1 -1) </details> ### 📄 Description # Pull Request Checklist **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ ] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? # Changelog Entry ### Description On ratelimiting, it is not easily shown what goes wrong, as one receives the full stack trace as seen here: https://github.com/open-webui/open-webui/discussions/11503 This should be improved by catching the RatelimitException and only logging an error for this. We could improve this as well by suggesting to reduce the concurrent requests..? ### Fixed Further fixes include * fix `search_results` might being out of scope * ddgs.text does already always return a list * move from deprecated "api" backend to lite (see https://github.com/deedy5/duckduckgo_search/commit/3ee8e08b1c8efc9b7356f406db299f1114dc4860 ) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 04:33:07 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#22986