Before submitting, make sure you've checked the following:
Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
It seems that there are no documentation right now.
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests for validating the changes?
Before this modificaiton input:prompt:submit was ignored without prompt set, now it is accepted and the specified text is submit, by my developping Action function.
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
BREAKING CHANGE: Significant changes that may affect compatibility
build: Changes that affect the build system or external dependencies
ci: Changes to our continuous integration processes or workflows
chore: Refactor, cleanup, or other non-functional code changes
docs: Documentation update or addition
feat: Introduces a new feature or enhancement to the codebase
fix: Bug fix or error correction
i18n: Internationalization or localization changes
perf: Performance improvement
refactor: Code restructuring for better maintainability, readability, or scalability
style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
test: Adding missing tests or correcting existing tests
WIP: Work in progress, a temporary label for incomplete or ongoing work
Changelog Entry
Description
Fix incosistent value check within the onMessageHandler() method of Chat.svelte.
In the input:prompt:submit event case, there seems to be an inconsistency between what is checked and what is used. The method calls submitPrompt(event.data.text) but it checks if prompt !== '' instead of checking event.data.text. Since prompt is cleared in submitPrompt(), this check has no meaningful purpose.
Added
None
Changed
None
Deprecated
None
Removed
None
Fixed
Fix incosistent value check within the onMessageHandler() method of Chat.svelte, for the case of input:prompt:submit event.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/open-webui/open-webui/pull/12168
**Author:** [@yak1ex](https://github.com/yak1ex)
**Created:** 3/29/2025
**Status:** ✅ Merged
**Merged:** 3/29/2025
**Merged by:** [@tjbck](https://github.com/tjbck)
**Base:** `dev` ← **Head:** `fix_inconsistent_value_check_in_onMessageHandler_in_Chat_svelte`
---
### 📝 Commits (1)
- [`c1f189a`](https://github.com/open-webui/open-webui/commit/c1f189a602b6ce224c782688a98357394c66dd3f) Fix inconsistent value check.
### 📊 Changes
**1 file changed** (+1 additions, -1 deletions)
<details>
<summary>View changed files</summary>
📝 `src/lib/components/chat/Chat.svelte` (+1 -1)
</details>
### 📄 Description
# Pull Request Checklist
Discussion here: https://github.com/open-webui/open-webui/discussions/11980
**Before submitting, make sure you've checked the following:**
- [x] **Target branch:** Please verify that the pull request targets the `dev` branch.
- [x] **Description:** Provide a concise description of the changes made in this pull request.
- [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description.
- [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources?
- It seems that there are no documentation right now.
- [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation?
- [ ] **Testing:** Have you written and run sufficient tests for validating the changes?
- Before this modificaiton `input:prompt:submit` was ignored without `prompt` set, now it is accepted and the specified text is submit, by my developping Action function.
- [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
- [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following:
- **BREAKING CHANGE**: Significant changes that may affect compatibility
- **build**: Changes that affect the build system or external dependencies
- **ci**: Changes to our continuous integration processes or workflows
- **chore**: Refactor, cleanup, or other non-functional code changes
- **docs**: Documentation update or addition
- **feat**: Introduces a new feature or enhancement to the codebase
- **fix**: Bug fix or error correction
- **i18n**: Internationalization or localization changes
- **perf**: Performance improvement
- **refactor**: Code restructuring for better maintainability, readability, or scalability
- **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
- **test**: Adding missing tests or correcting existing tests
- **WIP**: Work in progress, a temporary label for incomplete or ongoing work
# Changelog Entry
### Description
- Fix incosistent value check within the `onMessageHandler()` method of `Chat.svelte`.
- In the `input:prompt:submit` event case, there seems to be an inconsistency between what is checked and what is used. The method calls submitPrompt(event.data.text) but it checks if prompt !== '' instead of checking event.data.text. Since prompt is cleared in submitPrompt(), this check has no meaningful purpose.
### Added
- None
### Changed
- None
### Deprecated
- None
### Removed
- None
### Fixed
- Fix incosistent value check within the onMessageHandler() method of Chat.svelte, for the case of `input:prompt:submit` event.
### Security
- None
### Breaking Changes
- **BREAKING CHANGE**: None
---
### Additional Information
- Related discussion: https://github.com/open-webui/open-webui/discussions/11980
### Screenshots or Videos
- None
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/open-webui/open-webui/pull/12168
Author: @yak1ex
Created: 3/29/2025
Status: ✅ Merged
Merged: 3/29/2025
Merged by: @tjbck
Base:
dev← Head:fix_inconsistent_value_check_in_onMessageHandler_in_Chat_svelte📝 Commits (1)
c1f189aFix inconsistent value check.📊 Changes
1 file changed (+1 additions, -1 deletions)
View changed files
📝
src/lib/components/chat/Chat.svelte(+1 -1)📄 Description
Pull Request Checklist
Discussion here: https://github.com/open-webui/open-webui/discussions/11980
Before submitting, make sure you've checked the following:
devbranch.input:prompt:submitwas ignored withoutpromptset, now it is accepted and the specified text is submit, by my developping Action function.Changelog Entry
Description
onMessageHandler()method ofChat.svelte.input:prompt:submitevent case, there seems to be an inconsistency between what is checked and what is used. The method calls submitPrompt(event.data.text) but it checks if prompt !== '' instead of checking event.data.text. Since prompt is cleared in submitPrompt(), this check has no meaningful purpose.Added
Changed
Deprecated
Removed
Fixed
input:prompt:submitevent.Security
Breaking Changes
Additional Information
Screenshots or Videos
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.