Before submitting, make sure you've checked the following:
Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests for validating the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? Review comment: The code could be slightly refactored to use conditionals to decrease code duplication, but conditional element types in jsx-style code are notoriously hard to parse, so a bit of duplication doesn't seem too terrible.
Prefix: To clearly categorize this pull request, prefix the pull request title, using one of the following: Comment: Technically this could be a bug fix, depending on the intention for string valves in the first place.
Changelog Entry
💬Allow newlines in string valves: You can now put newlines in valves of type string.
Description
This code conditionally renders the valve input as a <textarea> if the valve is of type string - this allows adding newlines to the string that gets saved to the backend.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/open-webui/open-webui/pull/11647
**Author:** [@kaytwo](https://github.com/kaytwo)
**Created:** 3/13/2025
**Status:** ✅ Merged
**Merged:** 3/15/2025
**Merged by:** [@tjbck](https://github.com/tjbck)
**Base:** `dev` ← **Head:** `multiline-valves`
---
### 📝 Commits (1)
- [`53292e7`](https://github.com/open-webui/open-webui/commit/53292e7d12aac1d3ba1ab0dd39fe860c60755a65) allow string valves to include newlines
### 📊 Changes
**1 file changed** (+12 additions, -1 deletions)
<details>
<summary>View changed files</summary>
📝 `src/lib/components/common/Valves.svelte` (+12 -1)
</details>
### 📄 Description
# Pull Request Checklist
**Before submitting, make sure you've checked the following:**
- [x] **Target branch:** Please verify that the pull request targets the `dev` branch.
- [x] **Description:** Provide a concise description of the changes made in this pull request.
- [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description.
- [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources?
- [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation?
- [x] **Testing:** Have you written and run sufficient tests for validating the changes?
- [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
**Review comment**: The code could be slightly refactored to use conditionals to decrease code duplication, but conditional element types in jsx-style code are notoriously hard to parse, so a bit of duplication doesn't seem too terrible.
- [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title, using one of the following:
**Comment:** Technically this could be a bug fix, depending on the intention for string valves in the first place.
# Changelog Entry
- 💬 **Allow newlines in string valves**: You can now put newlines in valves of type `string`.
### Description
This code conditionally renders the valve input as a `<textarea>` if the valve is of type string - this allows adding newlines to the string that gets saved to the backend.
---
### Additional Information
Relevant discussion post: #11646
### Screenshots or Videos
<img width="510" alt="Untitled" src="https://github.com/user-attachments/assets/f3172a79-0af3-4ae8-ab80-51d5037746c7" />
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/open-webui/open-webui/pull/11647
Author: @kaytwo
Created: 3/13/2025
Status: ✅ Merged
Merged: 3/15/2025
Merged by: @tjbck
Base:
dev← Head:multiline-valves📝 Commits (1)
53292e7allow string valves to include newlines📊 Changes
1 file changed (+12 additions, -1 deletions)
View changed files
📝
src/lib/components/common/Valves.svelte(+12 -1)📄 Description
Pull Request Checklist
Before submitting, make sure you've checked the following:
devbranch.Review comment: The code could be slightly refactored to use conditionals to decrease code duplication, but conditional element types in jsx-style code are notoriously hard to parse, so a bit of duplication doesn't seem too terrible.
Comment: Technically this could be a bug fix, depending on the intention for string valves in the first place.
Changelog Entry
string.Description
This code conditionally renders the valve input as a
<textarea>if the valve is of type string - this allows adding newlines to the string that gets saved to the backend.Additional Information
Relevant discussion post: #11646
Screenshots or Videos
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.