[PR #11515] [MERGED] fix: url value when response contains url tag #22751

New Issue

GiteaMirror · 2026-04-20T04:22:17-05:00

GiteaMirror commented

2026-04-20 04:22:17 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/11515
Author: @davizucon
Created: 3/10/2025
Status: ✅ Merged
Merged: 3/11/2025
Merged by: @tjbck

Base: dev ← Head: main

📝 Commits (3)

846509b fix url value when response contains url tag
453200c fix code format
b1224b6 fix code format

📊 Changes

1 file changed (+2 additions, -4 deletions)

View changed files

📝 backend/open_webui/routers/images.py (+2 -4)

📄 Description

When the response contains b64_json, the "url" tag still exists but comes as null, the logic is to resolve this point where it contains the url tag, but empty, thus directing to b64_json

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests for validating the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

observing the response, url comes as null, when the b64_json is filled, this PR addresses this correction.

Changed

backend/open_webui/routers/images.py

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/11515 **Author:** [@davizucon](https://github.com/davizucon) **Created:** 3/10/2025 **Status:** ✅ Merged **Merged:** 3/11/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `main` --- ### 📝 Commits (3) - [`846509b`](https://github.com/open-webui/open-webui/commit/846509bf9fc1a925c27e800fb975e78e4b920e4c) fix url value when response contains url tag - [`453200c`](https://github.com/open-webui/open-webui/commit/453200ca1e2a7ac0ccf955c01b2c8c58d77342f4) fix code format - [`b1224b6`](https://github.com/open-webui/open-webui/commit/b1224b6839e88fec57c3869e453240c6f7c64f6d) fix code format ### 📊 Changes **1 file changed** (+2 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/images.py` (+2 -4) </details> ### 📄 Description When the response contains b64_json, the "url" tag still exists but comes as null, the logic is to resolve this point where it contains the url tag, but empty, thus directing to b64_json # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [ ] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ ] **Testing:** Have you written and run sufficient tests for validating the changes? - [ ] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [ ] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - observing the response, url comes as null, when the b64_json is filled, this PR addresses this correction. ### Changed - backend/open_webui/routers/images.py --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-20 04:22:17 -05:00

GiteaMirror closed this issue

2026-04-20 04:22:19 -05:00

GiteaMirror referenced this issue

2026-04-20 06:44:24 -05:00

[PR #22751] [CLOSED] fix: handle null user in shared chat view #26843

GiteaMirror referenced this issue

2026-04-25 09:33:46 -05:00

[GH-ISSUE #22742] issue: Shared Chats Crash with `Uncaught TypeError: can't access property "id", Z() is null` #35334

GiteaMirror referenced this issue

2026-04-25 14:22:08 -05:00

[PR #22751] [CLOSED] fix: handle null user in shared chat view #42473