[PR #11141] [MERGED] fix: correct parameter name for MilvusClient instantiation #22664

New Issue

GiteaMirror · 2026-04-20T04:18:14-05:00

GiteaMirror commented

2026-04-20 04:18:14 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/11141
Author: @Youggls
Created: 3/4/2025
Status: ✅ Merged
Merged: 3/4/2025
Merged by: @tjbck

Base: dev ← Head: dev

📝 Commits (1)

67ed61d fixbug: correct parameter name for MilvusClient instantiation

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 backend/open_webui/retrieval/vector/dbs/milvus.py (+2 -2)

📄 Description

Replace incorrect parameter 'database=MILVUS_DB' with valid 'db_name=MILVUS_DB'

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests for validating the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Description:

Correct parameter name in MilvusClient instantiation to resolve initialization errors.

Fixed

Fixed incorrect parameter name database=MILVUS_DB in MilvusClient instantiation, replacing it with the valid parameter db_name=MILVUS_DB as per the MilvusClient documentation.

Additional Information

Reference: The parameter name db_name is explicitly defined in the MilvusClient documentation for database specification.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/11141 **Author:** [@Youggls](https://github.com/Youggls) **Created:** 3/4/2025 **Status:** ✅ Merged **Merged:** 3/4/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `dev` --- ### 📝 Commits (1) - [`67ed61d`](https://github.com/open-webui/open-webui/commit/67ed61d022a24067789a79e5f06bc8a8e6d1e9f8) fixbug: correct parameter name for MilvusClient instantiation ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/retrieval/vector/dbs/milvus.py` (+2 -2) </details> ### 📄 Description Replace incorrect parameter 'database=MILVUS_DB' with valid 'db_name=MILVUS_DB' # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [ ] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ ] **Testing:** Have you written and run sufficient tests for validating the changes? - [ ] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work ## Description: Correct parameter name in MilvusClient instantiation to resolve initialization errors. ## Fixed - Fixed incorrect parameter name `database=MILVUS_DB` in MilvusClient instantiation, replacing it with the valid parameter `db_name=MILVUS_DB` as per the [MilvusClient documentation](https://milvus.io/api-reference/pymilvus/v2.5.x/MilvusClient/Client/MilvusClient.md). ### Additional Information - **Reference:** The parameter name `db_name` is explicitly defined in the [MilvusClient documentation](https://milvus.io/api-reference/pymilvus/v2.5.x/MilvusClient/Client/MilvusClient.md) for database specification. ![temp_image_20250304155441](https://github.com/user-attachments/assets/41ed3016-7b4e-437e-a709-ec894b405fc3) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-20 04:18:14 -05:00

GiteaMirror closed this issue