[PR #11073] [MERGED] fix: fix issue with call voice recording starting before voice detection #22654

New Issue

GiteaMirror · 2026-04-20T04:17:50-05:00

GiteaMirror commented

2026-04-20 04:17:50 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/11073
Author: @vincent-thevenin
Created: 3/3/2025
Status: ✅ Merged
Merged: 3/4/2025
Merged by: @tjbck

Base: dev ← Head: dev

📝 Commits (1)

4d6132b fix: fix issue with call voice recording starting before voice detection

📊 Changes

1 file changed (+4 additions, -2 deletions)

View changed files

📝 src/lib/components/chat/MessageInput/CallOverlay.svelte (+4 -2)

📄 Description

Pull Request Checklist

Duplicate of https://github.com/open-webui/open-webui/pull/9813
This PR is cleaned up, I accidentally merged and pushed upstream dev commits on the previous PR resulting in 400+ commits.

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests for validating the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

During calls, the STT recording was launched before the sound detection causing problems in the issues below. Changed the call logic to start recording only after sound has been detected.
Fix for issue https://github.com/open-webui/open-webui/issues/7509 where the STT records too early and retrofeeds the TTS into the call when using speakers, also fixes https://github.com/open-webui/open-webui/discussions/6711#discussion-7425349
Fix silence recording at the start of a new utterance causing STT hallucinations when using headset https://github.com/open-webui/open-webui/issues/6953

Added

N/A

Changed

Change call logic to wait for sound detection before starting the voice recording.

Deprecated

N/A

Removed

N/A

Fixed

Fix for issue https://github.com/open-webui/open-webui/issues/7509 where the STT records too early and retrofeeds the TTS into the call when using speakers, also fixes https://github.com/open-webui/open-webui/discussions/6711#discussion-7425349
Fix silence recording at the start of a new utterance causing STT hallucinations when using headset https://github.com/open-webui/open-webui/issues/6953

Security

N/A

Breaking Changes

N/A

Additional Information

N/A

Screenshots or Videos

https://github.com/user-attachments/assets/2f743883-0bac-4d8b-8d93-a7d7617e0844

https://github.com/user-attachments/assets/7338906c-233e-456c-a710-e011ab6d2d28

https://github.com/user-attachments/assets/6017cfcf-d9de-41ca-9c42-0240c4a6e7d7

https://github.com/user-attachments/assets/c1b49348-561a-4b69-97cb-be80f6d25b3a

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/11073 **Author:** [@vincent-thevenin](https://github.com/vincent-thevenin) **Created:** 3/3/2025 **Status:** ✅ Merged **Merged:** 3/4/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `dev` --- ### 📝 Commits (1) - [`4d6132b`](https://github.com/open-webui/open-webui/commit/4d6132b9de4abf3d0ba59728e9562176a0193e81) fix: fix issue with call voice recording starting before voice detection ### 📊 Changes **1 file changed** (+4 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/chat/MessageInput/CallOverlay.svelte` (+4 -2) </details> ### 📄 Description # Pull Request Checklist Duplicate of https://github.com/open-webui/open-webui/pull/9813 This PR is cleaned up, I accidentally merged and pushed upstream dev commits on the previous PR resulting in 400+ commits. ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests for validating the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - During calls, the STT recording was launched before the sound detection causing problems in the issues below. Changed the call logic to start recording only after sound has been detected. - Fix for issue https://github.com/open-webui/open-webui/issues/7509 where the STT records too early and retrofeeds the TTS into the call when using speakers, also fixes https://github.com/open-webui/open-webui/discussions/6711#discussion-7425349 - Fix silence recording at the start of a new utterance causing STT hallucinations when using headset https://github.com/open-webui/open-webui/issues/6953 ### Added - N/A ### Changed - Change call logic to wait for sound detection before starting the voice recording. ### Deprecated - N/A ### Removed - N/A ### Fixed - Fix for issue https://github.com/open-webui/open-webui/issues/7509 where the STT records too early and retrofeeds the TTS into the call when using speakers, also fixes https://github.com/open-webui/open-webui/discussions/6711#discussion-7425349 - Fix silence recording at the start of a new utterance causing STT hallucinations when using headset https://github.com/open-webui/open-webui/issues/6953 ### Security N/A ### Breaking Changes N/A --- ### Additional Information N/A ### Screenshots or Videos https://github.com/user-attachments/assets/2f743883-0bac-4d8b-8d93-a7d7617e0844 https://github.com/user-attachments/assets/7338906c-233e-456c-a710-e011ab6d2d28 https://github.com/user-attachments/assets/6017cfcf-d9de-41ca-9c42-0240c4a6e7d7 https://github.com/user-attachments/assets/c1b49348-561a-4b69-97cb-be80f6d25b3a --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-20 04:17:50 -05:00

GiteaMirror closed this issue

2026-04-20 04:17:50 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#22654