[PR #10752] [MERGED] refactor: replace print statements with logging #22587

Closed
opened 2026-04-20 04:15:17 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/10752
Author: @yvedeng
Created: 2/25/2025
Status: Merged
Merged: 2/25/2025
Merged by: @tjbck

Base: devHead: yvedeng/standardize-logging


📝 Commits (1)

  • 0e5d5ec refactor: replace print statements with logging for better error tracking

📊 Changes

34 files changed (+171 additions, -103 deletions)

View changed files

📝 backend/open_webui/config.py (+3 -3)
📝 backend/open_webui/models/chats.py (+8 -5)
📝 backend/open_webui/models/feedbacks.py (+1 -1)
📝 backend/open_webui/models/files.py (+1 -1)
📝 backend/open_webui/models/folders.py (+1 -1)
📝 backend/open_webui/models/functions.py (+4 -4)
📝 backend/open_webui/models/models.py (+2 -3)
📝 backend/open_webui/models/tags.py (+1 -1)
📝 backend/open_webui/models/tools.py (+4 -4)
📝 backend/open_webui/retrieval/models/colbert.py (+7 -1)
📝 backend/open_webui/retrieval/utils.py (+4 -4)
📝 backend/open_webui/retrieval/vector/dbs/chroma.py (+6 -1)
📝 backend/open_webui/retrieval/vector/dbs/milvus.py (+8 -4)
📝 backend/open_webui/retrieval/vector/dbs/pgvector.py (+21 -15)
📝 backend/open_webui/retrieval/vector/dbs/qdrant.py (+7 -2)
📝 backend/open_webui/routers/audio.py (+3 -4)
📝 backend/open_webui/routers/auths.py (+1 -1)
📝 backend/open_webui/routers/files.py (+1 -1)
📝 backend/open_webui/routers/functions.py (+10 -4)
📝 backend/open_webui/routers/groups.py (+11 -5)

...and 14 more files

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests for validating the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Refactoring the print statements by logging for better error tracking.

Changed

  • Replaced print by logging.

Additional Information

First of all, we love this project! Please keep up the great work! 👏

This PR aims to enhance the traceability of errors as we have been having a hard time tracking errors. I apologize in advance for the large number of files that were changed. 🙏 If you prefer, I'd be happy to break this into smaller PRs. Just let me know!


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/10752 **Author:** [@yvedeng](https://github.com/yvedeng) **Created:** 2/25/2025 **Status:** ✅ Merged **Merged:** 2/25/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `yvedeng/standardize-logging` --- ### 📝 Commits (1) - [`0e5d5ec`](https://github.com/open-webui/open-webui/commit/0e5d5ecb8190bf314b7b2363cceacde638a4a361) refactor: replace print statements with logging for better error tracking ### 📊 Changes **34 files changed** (+171 additions, -103 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/config.py` (+3 -3) 📝 `backend/open_webui/models/chats.py` (+8 -5) 📝 `backend/open_webui/models/feedbacks.py` (+1 -1) 📝 `backend/open_webui/models/files.py` (+1 -1) 📝 `backend/open_webui/models/folders.py` (+1 -1) 📝 `backend/open_webui/models/functions.py` (+4 -4) 📝 `backend/open_webui/models/models.py` (+2 -3) 📝 `backend/open_webui/models/tags.py` (+1 -1) 📝 `backend/open_webui/models/tools.py` (+4 -4) 📝 `backend/open_webui/retrieval/models/colbert.py` (+7 -1) 📝 `backend/open_webui/retrieval/utils.py` (+4 -4) 📝 `backend/open_webui/retrieval/vector/dbs/chroma.py` (+6 -1) 📝 `backend/open_webui/retrieval/vector/dbs/milvus.py` (+8 -4) 📝 `backend/open_webui/retrieval/vector/dbs/pgvector.py` (+21 -15) 📝 `backend/open_webui/retrieval/vector/dbs/qdrant.py` (+7 -2) 📝 `backend/open_webui/routers/audio.py` (+3 -4) 📝 `backend/open_webui/routers/auths.py` (+1 -1) 📝 `backend/open_webui/routers/files.py` (+1 -1) 📝 `backend/open_webui/routers/functions.py` (+10 -4) 📝 `backend/open_webui/routers/groups.py` (+11 -5) _...and 14 more files_ </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [ ] **Target branch:** Please verify that the pull request targets the `dev` branch. - [ ] **Description:** Provide a concise description of the changes made in this pull request. - [ ] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ ] **Testing:** Have you written and run sufficient tests for validating the changes? - [ ] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [ ] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description Refactoring the print statements by logging for better error tracking. ### Changed - Replaced `print` by logging. ### Additional Information First of all, we love this project! Please keep up the great work! 👏 This PR aims to enhance the traceability of errors as we have been having a hard time tracking errors. I apologize in advance for the large number of files that were changed. 🙏 If you prefer, I'd be happy to break this into smaller PRs. Just let me know! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 04:15:17 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#22587