[PR #10549] [MERGED] Fix: Ensure user_oauth_groups defaults to an empty list to prevent TypeError #22556

New Issue

GiteaMirror · 2026-04-20T04:14:08-05:00

GiteaMirror commented

2026-04-20 04:14:08 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/10549
Author: @jeannotdamoiseaux
Created: 2/21/2025
Status: ✅ Merged
Merged: 2/21/2025
Merged by: @tjbck

Base: dev ← Head: fix/oauth-groups-default-typeerror

📝 Commits (1)

d50098b Fix: Ensure user_oauth_groups defaults to an empty list to prevent TypeError

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 backend/open_webui/utils/oauth.py (+1 -1)

📄 Description

When the OAuth groups claim does not yield a list, user_oauth_groups was previously set to None, causing a TypeError during membership checks. Changed this default to an empty list ([]) to ensure the variable is always iterable, preventing errors for non-admin users while logging in.

This fix ensures stability in the update_user_groups function.

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

[ x ] Target branch: Please verify that the pull request targets the dev branch.
[ x ] Description: Provide a concise description of the changes made in this pull request.
[ x ] Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
[ x ] Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
[ x ] Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests for validating the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
[ x ] Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/10549 **Author:** [@jeannotdamoiseaux](https://github.com/jeannotdamoiseaux) **Created:** 2/21/2025 **Status:** ✅ Merged **Merged:** 2/21/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/oauth-groups-default-typeerror` --- ### 📝 Commits (1) - [`d50098b`](https://github.com/open-webui/open-webui/commit/d50098b62272203b5999edff735e18fff91a2446) Fix: Ensure `user_oauth_groups` defaults to an empty list to prevent TypeError ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/utils/oauth.py` (+1 -1) </details> ### 📄 Description When the OAuth groups claim does not yield a list, `user_oauth_groups` was previously set to None, causing a TypeError during membership checks. Changed this default to an empty list (`[]`) to ensure the variable is always iterable, preventing errors for non-admin users while logging in. This fix ensures stability in the `update_user_groups` function. # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [ x ] **Target branch:** Please verify that the pull request targets the `dev` branch. - [ x ] **Description:** Provide a concise description of the changes made in this pull request. - [ x ] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ x ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ x ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ ] **Testing:** Have you written and run sufficient tests for validating the changes? - [ ] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [ x ] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-20 04:14:08 -05:00

GiteaMirror closed this issue

2026-04-20 04:14:09 -05:00

GiteaMirror referenced this issue

2026-04-20 06:41:31 -05:00

[PR #22556] [CLOSED] fix: use max_completion_tokens for newer OpenAI models #26755

GiteaMirror referenced this issue

2026-04-25 14:17:52 -05:00

[PR #22556] [CLOSED] fix: use max_completion_tokens for newer OpenAI models #42385

GiteaMirror referenced this issue

2026-04-30 02:09:15 -05:00

[PR #22556] [CLOSED] fix: use max_completion_tokens for newer OpenAI models #49803