[PR #10521] [MERGED] **fix** Added support for stop parameter in OpenAI to Ollama conversion #22553

New Issue

GiteaMirror · 2026-04-20T04:14:02-05:00

GiteaMirror commented

2026-04-20 04:14:02 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/10521
Author: @Seniorsimo
Created: 2/21/2025
Status: ✅ Merged
Merged: 2/21/2025
Merged by: @tjbck

Base: dev ← Head: add-stop-parameter

📝 Commits (1)

fb3886c Added support for stop parameter

📊 Changes

1 file changed (+6 additions, -0 deletions)

View changed files

📝 backend/open_webui/utils/payload.py (+6 -0)

📄 Description

Pull Request Checklist

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests for validating the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Some agent library use the "stop" parameter to tell the model when to stop generating. The mapping from the OpenAI API to the Ollama was missing this parameter

Added

OpenAI to Ollama support for stop parameter

Additional Information
All the changes are tested and validated using this notebook file.
https://gist.github.com/Seniorsimo/214e39d7da6a72bff98f265a39c2fa14

Tested the varius intagration using:

OpenAI vs Open WebUI (gpt-3.5-turbo)
Ollama vs Open WebUI (qwen2.5:14b)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/10521 **Author:** [@Seniorsimo](https://github.com/Seniorsimo) **Created:** 2/21/2025 **Status:** ✅ Merged **Merged:** 2/21/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `add-stop-parameter` --- ### 📝 Commits (1) - [`fb3886c`](https://github.com/open-webui/open-webui/commit/fb3886cf04d1431e7dae6968f607634999404b45) Added support for stop parameter ### 📊 Changes **1 file changed** (+6 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/utils/payload.py` (+6 -0) </details> ### 📄 Description # Pull Request Checklist **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests for validating the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Some agent library use the "stop" parameter to tell the model when to stop generating. The mapping from the OpenAI API to the Ollama was missing this parameter ### Added - OpenAI to Ollama support for `stop` parameter --- Additional Information All the changes are tested and validated using this notebook file. https://gist.github.com/Seniorsimo/214e39d7da6a72bff98f265a39c2fa14 Tested the varius intagration using: OpenAI vs Open WebUI (gpt-3.5-turbo) Ollama vs Open WebUI (qwen2.5:14b) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-20 04:14:02 -05:00

GiteaMirror closed this issue

2026-04-20 04:14:03 -05:00

GiteaMirror referenced this issue

2026-04-25 09:30:06 -05:00

[GH-ISSUE #22553] issue: @mentions in channels do not work with direct connections #35273

GiteaMirror referenced this issue

2026-05-05 23:06:37 -05:00

[GH-ISSUE #22553] issue: @mentions in channels do not work with direct connections #58410

Sign in to join this conversation.