[PR #10515] [CLOSED] fix: milvus db minor fix #22552

Closed
opened 2026-04-20 04:14:00 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/10515
Author: @s-sajid-ali
Created: 2/21/2025
Status: Closed

Base: devHead: milvus_db_minor_fix


📝 Commits (1)

  • b1559f7 milvus: set database via using_database

📊 Changes

1 file changed (+3 additions, -2 deletions)

View changed files

📝 backend/open_webui/retrieval/vector/dbs/milvus.py (+3 -2)

📄 Description

Using db_name at Client instantiation was not enough to set the intended database. Set it explicitly via using_database instead: https://milvus.io/api-reference/pymilvus/v2.5.x/MilvusClient/Database/using_database.md

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Testing: Have you written and run sufficient tests for validating the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?

Changelog entry:

Fixed

MilvusClient was previously attempting to create collections in the default database. Switch to using_database to explicitly set the requested database.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/10515 **Author:** [@s-sajid-ali](https://github.com/s-sajid-ali) **Created:** 2/21/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `milvus_db_minor_fix` --- ### 📝 Commits (1) - [`b1559f7`](https://github.com/open-webui/open-webui/commit/b1559f72d0a782fb745e7c7c7bfbe131e791d045) milvus: set database via using_database ### 📊 Changes **1 file changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/retrieval/vector/dbs/milvus.py` (+3 -2) </details> ### 📄 Description Using `db_name` at Client instantiation was not enough to set the intended database. Set it explicitly via `using_database` instead: https://milvus.io/api-reference/pymilvus/v2.5.x/MilvusClient/Database/using_database.md - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Testing:** Have you written and run sufficient tests for validating the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? Changelog entry: ### Fixed MilvusClient was previously attempting to create collections in the `default` database. Switch to `using_database` to explicitly set the requested database. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 04:14:00 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#22552