[PR #10408] [MERGED] fix: respect proxy and timeout settings in audio-related aiohttp requests #22521

New Issue

GiteaMirror · 2026-04-20T04:12:46-05:00

GiteaMirror commented

2026-04-20 04:12:46 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/10408
Author: @hangxingliu
Created: 2/20/2025
Status: ✅ Merged
Merged: 2/20/2025
Merged by: @tjbck

Base: dev ← Head: liu/fix-proxy

📝 Commits (1)

90d9cda fix: respect proxy and timeout settings in audio-related aiohttp requests

📊 Changes

1 file changed (+7 additions, -3 deletions)

View changed files

📝 backend/open_webui/routers/audio.py (+7 -3)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests for validating the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Some of TTS outgoing requests from the server do not respect timeout/proxy env settings as described in the document

Fixed

Get and apply timeout settings before outgoing requests like what other outgoing requests do in this project. And add trust_env=True parameter to ensure aiohttp uses proxy configs from the environment variables.

Additional Information

I just realized this issue because the TTS feature doesn't work correctly in my strict network environment even though I have configured the relevant network proxy according to OpenWebUI official document.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/10408 **Author:** [@hangxingliu](https://github.com/hangxingliu) **Created:** 2/20/2025 **Status:** ✅ Merged **Merged:** 2/20/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `liu/fix-proxy` --- ### 📝 Commits (1) - [`90d9cda`](https://github.com/open-webui/open-webui/commit/90d9cdacfa461fd86a1b00a944e49301aa82ee3a) fix: respect proxy and timeout settings in audio-related aiohttp requests ### 📊 Changes **1 file changed** (+7 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/audio.py` (+7 -3) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests for validating the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description Some of TTS outgoing requests from the server do not respect timeout/proxy env settings as described in [the document](https://docs.openwebui.com/getting-started/env-configuration/) ### Fixed Get and apply timeout settings before outgoing requests like what other outgoing requests do in this project. And add `trust_env=True` parameter to ensure `aiohttp` uses proxy configs from the environment variables. --- ### Additional Information I just realized this issue because the TTS feature doesn't work correctly in my strict network environment even though I have configured the relevant network proxy according to OpenWebUI official document. - https://docs.openwebui.com/getting-started/env-configuration/#proxy-settings - https://github.com/open-webui/open-webui/blame/main/backend/open_webui/routers/openai.py#L57 - https://docs.aiohttp.org/en/stable/client_reference.html#aiohttp.ClientSession.trust_env --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-20 04:12:46 -05:00

GiteaMirror closed this issue

2026-04-20 04:12:47 -05:00

GiteaMirror referenced this issue

2026-04-25 09:29:29 -05:00

[GH-ISSUE #22521] feat: Optional Unicode support for usernames (NFC normalised, opt-in) #35261

GiteaMirror referenced this issue

2026-05-05 23:05:45 -05:00

[GH-ISSUE #22521] feat: Optional Unicode support for usernames (NFC normalised, opt-in) #58398

Sign in to join this conversation.