[PR #10403] [CLOSED] fix: source_idx allocation #22520

New Issue

GiteaMirror · 2026-04-20T04:12:42-05:00

GiteaMirror commented

2026-04-20 04:12:42 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/10403
Author: @leantli
Created: 2/20/2025
Status: ❌ Closed

Base: dev ← Head: fix/wrong_source_id

📝 Commits (1)

2a20566 fix: wrong source_idx

📊 Changes

1 file changed (+3 additions, -1 deletions)

View changed files

📝 backend/open_webui/utils/middleware.py (+3 -1)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests for validating the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Identified an issue in the source_idx assignment mechanism where multiple documents under the same source are being incorrectly assigned identical source_idx values. This creates potential conflicts during model analysis when processing the <source_idx>{source_idx}</source_idx> tag in prompts, as the model cannot reliably distinguish between different documents sharing the same source identifier.

Fixed

fix source_idx allocation

Screenshots or Videos

error scenario reproduction

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/10403 **Author:** [@leantli](https://github.com/leantli) **Created:** 2/20/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/wrong_source_id` --- ### 📝 Commits (1) - [`2a20566`](https://github.com/open-webui/open-webui/commit/2a20566d03deaf40a5ee0a9d077119cac94395f9) fix: wrong source_idx ### 📊 Changes **1 file changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/utils/middleware.py` (+3 -1) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests for validating the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Identified an issue in the source_idx assignment mechanism where multiple documents under the same source are being incorrectly assigned identical source_idx values. This creates potential conflicts during model analysis when processing the <source_idx>{source_idx}</source_idx> tag in prompts, as the model cannot reliably distinguish between different documents sharing the same source identifier. ### Fixed - fix source_idx allocation ### Screenshots or Videos error scenario reproduction <img width="1849" alt="error scenario reproduction" src="https://github.com/user-attachments/assets/34c93531-1a16-4aa4-a647-f948d2853a44" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-20 04:12:42 -05:00

GiteaMirror closed this issue

2026-04-20 04:12:43 -05:00

GiteaMirror referenced this issue

2026-04-25 09:29:27 -05:00

[GH-ISSUE #22520] feat: Bundled Ollama not exposing port #35260

GiteaMirror referenced this issue

2026-05-05 23:05:44 -05:00

[GH-ISSUE #22520] feat: Bundled Ollama not exposing port #58397

Sign in to join this conversation.