[PR #9641] [MERGED] Fix: GGUF model upload instability #22402

Closed
opened 2026-04-20 04:07:29 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/9641
Author: @SentinalMax
Created: 2/8/2025
Status: Merged
Merged: 2/8/2025
Merged by: @tjbck

Base: devHead: bugfix/GGUF-upload-issue


📝 Commits (1)

  • 95aaacf fixed GGUF model upload instability

📊 Changes

2 files changed (+81 additions, -51 deletions)

View changed files

📝 backend/open_webui/routers/ollama.py (+76 -47)
📝 backend/open_webui/utils/misc.py (+5 -4)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests for validating the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

GGUF file upload for Ollama will remain experimental (will not work for certain cases), file size exceeding 4gb are known to have issues with the upload process. I'll be moving this to discussion, however, If anyone's interested in fixing the issue, feel free to make a PR!

In response to issues uploading larger (~5-10+GB) GGUF files;

  • File is written to binary 2 MB at a time
  • File read back & sha256 hash calculated
  • Asynchronous upload_model function
  • Ensure file is uploaded to ollama blob's digest & call /api/create

Changed

  • Refactored / cleaned code in ollama.py & misc.py
  • Code refactored in misc.py related to sha256 calculation function

Fixed

  • Improved & stabilized file upload mechanism

Additional Information

Note: Plans to improve progress bar.

Screenshots or Videos

Screenshot from 2025-02-07 15-37-48


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/9641 **Author:** [@SentinalMax](https://github.com/SentinalMax) **Created:** 2/8/2025 **Status:** ✅ Merged **Merged:** 2/8/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `bugfix/GGUF-upload-issue` --- ### 📝 Commits (1) - [`95aaacf`](https://github.com/open-webui/open-webui/commit/95aaacfeb494a659be2b488a9237e20bec18d273) fixed GGUF model upload instability ### 📊 Changes **2 files changed** (+81 additions, -51 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/ollama.py` (+76 -47) 📝 `backend/open_webui/utils/misc.py` (+5 -4) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [ ] **Target branch:** Please verify that the pull request targets the `dev` branch. - [ ] **Description:** Provide a concise description of the changes made in this pull request. - [ ] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ ] **Testing:** Have you written and run sufficient tests for validating the changes? - [ ] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [ ] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - https://github.com/open-webui/open-webui/issues/499 - https://github.com/open-webui/open-webui/discussions/2805#discussioncomment-9659685 > GGUF file upload for Ollama will remain experimental (will not work for certain cases), file size exceeding 4gb are known to have issues with the upload process. I'll be moving this to discussion, however, If anyone's interested in fixing the issue, feel free to make a PR! In response to issues uploading larger (~5-10+GB) GGUF files; - File is written to binary 2 MB at a time - File read back & sha256 hash calculated - Asynchronous upload_model function - Ensure file is uploaded to ollama blob's digest & call /api/create ### Changed - Refactored / cleaned code in `ollama.py` & `misc.py` - Code refactored in `misc.py` related to sha256 calculation function ### Fixed - Improved & stabilized file upload mechanism --- ### Additional Information Note: Plans to improve progress bar. ### Screenshots or Videos ![Screenshot from 2025-02-07 15-37-48](https://github.com/user-attachments/assets/269508f3-70a6-4eda-8c08-aaed7f9c2374) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 04:07:29 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#22402