[PR #9003] [MERGED] Fix: Users with write adding docs to knowledge, deleting, and fixing read/write toggle on model & knowledge creation #22301

New Issue

GiteaMirror · 2026-04-20T04:03:41-05:00

GiteaMirror commented

2026-04-20 04:03:41 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/9003
Author: @tarmst
Created: 1/27/2025
Status: ✅ Merged
Merged: 1/27/2025
Merged by: @tjbck

Base: dev ← Head: fix-no-file-upload-for-write-groups

📝 Commits (1)

751a61a Adding more checks for write access. Adding accessRoles to Model & Knowledge creation

📊 Changes

6 files changed (+53 additions, -11 deletions)

View changed files

📝 backend/open_webui/routers/knowledge.py (+30 -6)
📝 backend/open_webui/routers/models.py (+5 -1)
📝 backend/open_webui/routers/prompts.py (+5 -1)
📝 backend/open_webui/routers/tools.py (+5 -1)
📝 src/lib/components/workspace/Knowledge/CreateKnowledgeBase.svelte (+4 -1)
📝 src/lib/components/workspace/Models/ModelEditor.svelte (+4 -1)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Associated issue: https://github.com/open-webui/open-webui/issues/8889

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests for validating the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
- fix: Bug fix or error correction

Changelog Entry

Description

Fixed users with write access not being able to add documents to knowledge, added more write access checks for deletion of models, prompts, tools & knowledge. Fixed being unable to click the read/write access toggle on groups on model & knowledge creation.

Fixed

Fixed users with write access to knowledge not being able to add documents.
Fixed users with write access to models/prompts/knowledge/tools not being able to delete them.
Fixed not being able to toggle read/write on the initial creation page of models & knowledge.

Additional Information

I had to add accessRoles definitions to the AccessControls of both ModelEditor & CreateKnowledgeBase, so that the read/write could be toggled. I'm not sure if this was the correct way to do this. Lmk if not.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/9003 **Author:** [@tarmst](https://github.com/tarmst) **Created:** 1/27/2025 **Status:** ✅ Merged **Merged:** 1/27/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix-no-file-upload-for-write-groups` --- ### 📝 Commits (1) - [`751a61a`](https://github.com/open-webui/open-webui/commit/751a61a3647c65c76b210ace75f235463cdf345c) Adding more checks for write access. Adding accessRoles to Model & Knowledge creation ### 📊 Changes **6 files changed** (+53 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/knowledge.py` (+30 -6) 📝 `backend/open_webui/routers/models.py` (+5 -1) 📝 `backend/open_webui/routers/prompts.py` (+5 -1) 📝 `backend/open_webui/routers/tools.py` (+5 -1) 📝 `src/lib/components/workspace/Knowledge/CreateKnowledgeBase.svelte` (+4 -1) 📝 `src/lib/components/workspace/Models/ModelEditor.svelte` (+4 -1) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. Associated issue: https://github.com/open-webui/open-webui/issues/8889 **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests for validating the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **fix**: Bug fix or error correction # Changelog Entry ### Description - Fixed users with write access not being able to add documents to knowledge, added more write access checks for deletion of models, prompts, tools & knowledge. Fixed being unable to click the read/write access toggle on groups on model & knowledge creation. ### Fixed - Fixed users with write access to knowledge not being able to add documents. - Fixed users with write access to models/prompts/knowledge/tools not being able to delete them. - Fixed not being able to toggle read/write on the initial creation page of models & knowledge. --- ### Additional Information I had to add accessRoles definitions to the AccessControls of both ModelEditor & CreateKnowledgeBase, so that the read/write could be toggled. I'm not sure if this was the correct way to do this. Lmk if not. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-20 04:03:41 -05:00

GiteaMirror closed this issue

2026-04-20 04:03:42 -05:00

GiteaMirror referenced this issue

2026-04-20 06:35:45 -05:00

[PR #22301] [MERGED] perf(models): batch-fetch function valves to eliminate N+1 queries #26599

GiteaMirror referenced this issue

2026-04-25 14:12:57 -05:00

[PR #22301] [MERGED] perf(models): batch-fetch function valves to eliminate N+1 queries #42229

GiteaMirror referenced this issue

2026-04-30 01:57:23 -05:00

[PR #22301] [MERGED] perf(models): batch-fetch function valves to eliminate N+1 queries #49647