Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.
Before submitting, make sure you've checked the following:
Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests for validating the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
fix: Bug fix or error correction
Changelog Entry
Description
Fixes a bug. The LDAP auth user does not respect the default role in database.
Currently, the LDAP user is always be set to the role pending even the role user is set in web UI.
Added
Backend: Retrieve the role for LDAP user from config
Changed
[List any changes, updates, refactorings, or optimizations]
Deprecated
[List any deprecated functionality or features that have been removed]
Removed
[List any removed features, files, or functionalities]
Fixed
[List any fixes, corrections, or bug fixes]
Security
[List any new or updated security-related changes, including vulnerability fixes]
Breaking Changes
BREAKING CHANGE: [List any breaking changes affecting compatibility or functionality]
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/open-webui/open-webui/pull/6952
**Author:** [@zhan9san](https://github.com/zhan9san)
**Created:** 11/14/2024
**Status:** ❌ Closed
**Base:** `dev` ← **Head:** `feature/add-role-for-ldap-user`
---
### 📝 Commits (1)
- [`3982c55`](https://github.com/open-webui/open-webui/commit/3982c55e618ba2af1368759c4fa6b46adb0cd726) Add correct default role
### 📊 Changes
**1 file changed** (+13 additions, -1 deletions)
<details>
<summary>View changed files</summary>
📝 `backend/open_webui/apps/webui/routers/auths.py` (+13 -1)
</details>
### 📄 Description
# Pull Request Checklist
fixes #6943
### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request.
**Before submitting, make sure you've checked the following:**
- [x] **Target branch:** Please verify that the pull request targets the `dev` branch.
- [x] **Description:** Provide a concise description of the changes made in this pull request.
- [ ] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description.
- [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources?
- [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation?
- [ ] **Testing:** Have you written and run sufficient tests for validating the changes?
- [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
- [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following:
- **fix**: Bug fix or error correction
# Changelog Entry
### Description
Fixes a bug. The LDAP auth user does not respect the default role in database.
Currently, the LDAP user is always be set to the role `pending` even the role `user` is set in web UI.
### Added
Backend: Retrieve the role for LDAP user from config
### Changed
- [List any changes, updates, refactorings, or optimizations]
### Deprecated
- [List any deprecated functionality or features that have been removed]
### Removed
- [List any removed features, files, or functionalities]
### Fixed
- [List any fixes, corrections, or bug fixes]
### Security
- [List any new or updated security-related changes, including vulnerability fixes]
### Breaking Changes
- **BREAKING CHANGE**: [List any breaking changes affecting compatibility or functionality]
---
### Additional Information
Related to #6743
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/open-webui/open-webui/pull/6952
Author: @zhan9san
Created: 11/14/2024
Status: ❌ Closed
Base:
dev← Head:feature/add-role-for-ldap-user📝 Commits (1)
3982c55Add correct default role📊 Changes
1 file changed (+13 additions, -1 deletions)
View changed files
📝
backend/open_webui/apps/webui/routers/auths.py(+13 -1)📄 Description
Pull Request Checklist
fixes #6943
Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.
Before submitting, make sure you've checked the following:
devbranch.Changelog Entry
Description
Fixes a bug. The LDAP auth user does not respect the default role in database.
Currently, the LDAP user is always be set to the role
pendingeven the roleuseris set in web UI.Added
Backend: Retrieve the role for LDAP user from config
Changed
Deprecated
Removed
Fixed
Security
Breaking Changes
Additional Information
Related to #6743
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.