eab3078 Chat completion 401 when no Authorization header
📊 Changes
1 file changed (+16 additions, -4 deletions)
View changed files
📝backend/open_webui/main.py (+16 -4)
📄 Description
Pull Request Checklist
Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.
Before submitting, make sure you've checked the following:
Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests for validating the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
BREAKING CHANGE: Significant changes that may affect compatibility
build: Changes that affect the build system or external dependencies
ci: Changes to our continuous integration processes or workflows
chore: Refactor, cleanup, or other non-functional code changes
docs: Documentation update or addition
feat: Introduces a new feature or enhancement to the codebase
fix: Bug fix or error correction
i18n: Internationalization or localization changes
perf: Performance improvement
refactor: Code restructuring for better maintainability, readability, or scalability
style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
test: Adding missing tests or correcting existing tests
WIP: Work in progress, a temporary label for incomplete or ongoing work
Changelog Entry
Description
When we send a request to /api/chat/completions without the Authorization header, the server just crashes and creates a stack trace, returning "Internal Server Error" to the calling client because of a KeyError. With this fix, the server sends a 401 to the client with the content {"detail": "Not authenticated"}.
Fixed
Add a try/except handle the case where there is no Authorization header. Returns status 401 Not Authorized and {"detail":"Not authenticated"} body if the header is not found.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/open-webui/open-webui/pull/5773
**Author:** [@HaldiH](https://github.com/HaldiH)
**Created:** 9/27/2024
**Status:** ✅ Merged
**Merged:** 9/27/2024
**Merged by:** [@tjbck](https://github.com/tjbck)
**Base:** `dev` ← **Head:** `main`
---
### 📝 Commits (1)
- [`eab3078`](https://github.com/open-webui/open-webui/commit/eab30781e0e02033c66df1f659118204ab3bbc98) Chat completion 401 when no Authorization header
### 📊 Changes
**1 file changed** (+16 additions, -4 deletions)
<details>
<summary>View changed files</summary>
📝 `backend/open_webui/main.py` (+16 -4)
</details>
### 📄 Description
# Pull Request Checklist
### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request.
**Before submitting, make sure you've checked the following:**
- [X] **Target branch:** Please verify that the pull request targets the `dev` branch.
- [X] **Description:** Provide a concise description of the changes made in this pull request.
- [ ] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description.
- [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources?
- [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation?
- [ ] **Testing:** Have you written and run sufficient tests for validating the changes?
- [X] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
- [X] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following:
- **BREAKING CHANGE**: Significant changes that may affect compatibility
- **build**: Changes that affect the build system or external dependencies
- **ci**: Changes to our continuous integration processes or workflows
- **chore**: Refactor, cleanup, or other non-functional code changes
- **docs**: Documentation update or addition
- **feat**: Introduces a new feature or enhancement to the codebase
- **fix**: Bug fix or error correction
- **i18n**: Internationalization or localization changes
- **perf**: Performance improvement
- **refactor**: Code restructuring for better maintainability, readability, or scalability
- **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
- **test**: Adding missing tests or correcting existing tests
- **WIP**: Work in progress, a temporary label for incomplete or ongoing work
# Changelog Entry
### Description
- When we send a request to `/api/chat/completions` without the `Authorization` header, the server just crashes and creates a stack trace, returning "Internal Server Error" to the calling client because of a `KeyError`. With this fix, the server sends a 401 to the client with the content `{"detail": "Not authenticated"}`.
### Fixed
- Add a try/except handle the case where there is no `Authorization` header. Returns status 401 Not Authorized and `{"detail":"Not authenticated"}` body if the header is not found.
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/open-webui/open-webui/pull/5773
Author: @HaldiH
Created: 9/27/2024
Status: ✅ Merged
Merged: 9/27/2024
Merged by: @tjbck
Base:
dev← Head:main📝 Commits (1)
eab3078Chat completion 401 when no Authorization header📊 Changes
1 file changed (+16 additions, -4 deletions)
View changed files
📝
backend/open_webui/main.py(+16 -4)📄 Description
Pull Request Checklist
Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.
Before submitting, make sure you've checked the following:
devbranch.Changelog Entry
Description
/api/chat/completionswithout theAuthorizationheader, the server just crashes and creates a stack trace, returning "Internal Server Error" to the calling client because of aKeyError. With this fix, the server sends a 401 to the client with the content{"detail": "Not authenticated"}.Fixed
Authorizationheader. Returns status 401 Not Authorized and{"detail":"Not authenticated"}body if the header is not found.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.