github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-05-06 10:58:17 -05:00
Code Issues 1.3k Packages Projects Releases 126 Wiki Activity

[PR #4598] [MERGED] refactor: Remove unused frontend functions migrated to backend #21519

New Issue
Closed
opened 2026-04-20 03:34:05 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 03:34:05 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/4598
Author: @michaelpoluektov
Created: 8/14/2024
Status: ✅ Merged
Merged: 8/14/2024
Merged by: @tjbck

Base: dev ← Head: cleanup-frontend

📝 Commits (1)

  • ec9e0da remove frontend functions migrated to backend

📊 Changes

2 files changed (+0 additions, -175 deletions)

View changed files

📝 src/lib/apis/ollama/index.ts (+0 -50)
📝 src/lib/apis/openai/index.ts (+0 -125)

📄 Description

Pull Request Checklist

I removed this because those are the functions that called chat/completions endpoint (which I'm refactoring).:

I saw a few more functions that weren't called but I'm not sure if those are for features that are WIP (confirmSelectCollaborativeChat, generatePrompt in Ollama and potentially others). Might be worth having a look and deleting anything else that's unused for better DX.

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests for validating the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Remove frontend functions migrated to backend:

  • openai generateSearchQuery and generateTitle
  • ollama generateTitle

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/4598 **Author:** [@michaelpoluektov](https://github.com/michaelpoluektov) **Created:** 8/14/2024 **Status:** ✅ Merged **Merged:** 8/14/2024 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `cleanup-frontend` --- ### 📝 Commits (1) - [`ec9e0da`](https://github.com/open-webui/open-webui/commit/ec9e0dadea01bb59493d19c068a37d67d7467d80) remove frontend functions migrated to backend ### 📊 Changes **2 files changed** (+0 additions, -175 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/apis/ollama/index.ts` (+0 -50) 📝 `src/lib/apis/openai/index.ts` (+0 -125) </details> ### 📄 Description # Pull Request Checklist I removed this because those are the functions that called `chat/completions` endpoint (which I'm refactoring).: I saw a few more functions that weren't called but I'm not sure if those are for features that are WIP (`confirmSelectCollaborativeChat`, `generatePrompt` in Ollama and potentially others). Might be worth having a look and deleting anything else that's unused for better DX. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests for validating the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description Remove frontend functions migrated to backend: - openai `generateSearchQuery` and `generateTitle` - ollama `generateTitle` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 03:34:05 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#21519
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?