[PR #4429] [CLOSED] fix: #4158 allow reconnection when websocket is closed #21486

New Issue

GiteaMirror · 2026-04-20T03:32:56-05:00

GiteaMirror commented

2026-04-20 03:32:56 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/4429
Author: @nowheresly
Created: 8/7/2024
Status: ❌ Closed

Base: main ← Head: fix4158

📝 Commits (1)

4718ad8 fix: #4158 do not return error 500 when websocket is closed

📊 Changes

3 files changed (+9 additions, -4 deletions)

View changed files

📝 backend/apps/socket/main.py (+4 -0)
📝 backend/main.py (+4 -4)
📝 src/lib/apis/index.ts (+1 -0)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

[x ] Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests for validating the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Prevent the backend from responding http error 500 when session_id is not provided by the client

Fixed

Fix issue #4158, ensure session_id is optional on the backend side.

Additional Information

I think this bug has been introduced with the commit d97a4d687e (diff-c867e0c9c90c94b02a2de567f2210ca9e600180d8fa3d6b121c7eb54da39a4edR345)
we can see that session_id is optional on the client-side (see here: c869652ef4/src/lib/components/chat/Chat.svelte (L394))
but this session_id is mandatory on the server-side, thus provoking an http 500 error when session_id is not provided (see here: c869652ef4/backend/main.py (L1180)).

Of course, if the websocket connection is not closed, we don't get this error. Yet, I think it is important to be robust in such situation. Probably the websocket connection should be re-established as well ?

Dear @tjbck , any insight would be welcome!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/4429 **Author:** [@nowheresly](https://github.com/nowheresly) **Created:** 8/7/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix4158` --- ### 📝 Commits (1) - [`4718ad8`](https://github.com/open-webui/open-webui/commit/4718ad89e1ae3e5eff9f1ae9fe3b85f9379093e4) fix: #4158 do not return error 500 when websocket is closed ### 📊 Changes **3 files changed** (+9 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `backend/apps/socket/main.py` (+4 -0) 📝 `backend/main.py` (+4 -4) 📝 `src/lib/apis/index.ts` (+1 -0) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x ] **Target branch:** Please verify that the pull request targets the `dev` branch. - [ ] **Description:** Provide a concise description of the changes made in this pull request. - [ ] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ ] **Testing:** Have you written and run sufficient tests for validating the changes? - [ ] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [ ] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Prevent the backend from responding http error 500 when session_id is not provided by the client ### Fixed - Fix issue #4158, ensure `session_id` is optional on the backend side. --- ### Additional Information - I think this bug has been introduced with the commit https://github.com/open-webui/open-webui/commit/d97a4d687ebc065ae4ec2a45b24c775e052ab38c#diff-c867e0c9c90c94b02a2de567f2210ca9e600180d8fa3d6b121c7eb54da39a4edR345 - we can see that session_id is optional on the client-side (see here: https://github.com/open-webui/open-webui/blob/c869652ef4907dd123a140d9a08a0c239e690b08/src/lib/components/chat/Chat.svelte#L394) - but this session_id is mandatory on the server-side, thus provoking an http 500 error when session_id is not provided (see here: https://github.com/open-webui/open-webui/blob/c869652ef4907dd123a140d9a08a0c239e690b08/backend/main.py#L1180). Of course, if the websocket connection is not closed, we don't get this error. Yet, I think it is important to be robust in such situation. Probably the websocket connection should be re-established as well ? Dear @tjbck , any insight would be welcome! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-20 03:32:56 -05:00

GiteaMirror closed this issue