mirror of
https://github.com/open-webui/open-webui.git
synced 2026-05-06 19:08:59 -05:00
feat: model name sanitisation #172
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @robertvazan on GitHub (Jan 12, 2024).
Bug Report
Description
Bug Summary:
Model download does not strip whitespace from model name. This results in confusing error messages. Whitespace gets there easily when copy-n-pasting from ollama library.
Steps to Reproduce:
Just enter " tinyllama" or "tinyllama " (with the space) in the form and click download.
Expected Behavior:
Whitespace is stripped and download starts.
Actual Behavior:
Error "pull model manifest: file does not exist"
Reproduction Details
Confirmation:
Additional Information
It would be great to also accept the full command from ollama library, e.g. "ollama run tinyllama", or an URL, which are both easy to copy-n-paste.
@anuraagdjain commented on GitHub (Jan 13, 2024):
Good catch, missed this case when refactored the logic for multiple downloads (PR).