mirror of
https://github.com/open-webui/open-webui.git
synced 2026-05-06 02:48:13 -05:00
[GH-ISSUE #10387] DATABASE_URL cannot contain @ sign in username #15876
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/open-webui#15876
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @bassettb on GitHub (Feb 19, 2025).
Original GitHub issue: https://github.com/open-webui/open-webui/issues/10387
Bug Report
Installation Method
kubernetes deployment
Environment
Open WebUI Version: v0.5.14
Operating System: linux
Confirmation:
Expected Behavior:
When specifying an external database using the DATABASE_URL, the username might contain an @ sign, just like the password might contain special characters. The @ sign is stored as %40 in the DATABASE_URL value. OpenWebUI should properly decode this URL and turn %40 back into @ before sending the username to the database.
I know the lack of password in my example might cause confusion. But this is completely normal in a Cloud environment.
Access is defined in Terraform and controlled using IAM service accounts which contain @ signs. GCP's CloudSQL supports adding the service account as a database user where no password is necessary. We use this extensively in our cloud projects. It's clear from the code that the password (or lack of) is unrelated.
Example of a URL using a GCP service account username:
"postgresql://open-webui-svc%40myproject.iam@localhost/owui_gen"Actual Behavior:
The username is not properly parsed by the peewee library. The escaped username (open-webui-svc%40myproject.iam) is sent to postgres and postgres returns an error mentioning the escaped username:
Failed to initialize the database connection: connection to server at "localhost" (127.0.0.1), port 5432 failed: FATAL: password authentication failed for user "open-webui-svc%40myproject.iam"Description
Bug Summary:
A Database URL might contain escaped (URL-encoded) characters in the username. Open-WebUI should decode these correctly.
Reproduction Details
Steps to Reproduce:
Set up a postgres database.
Create a user with an @ sign in the name.
Set DATABASE_URL to point to your database with the username properly encoded.
Additional Information
Offending line of code is here. They call an
unquotefunction on the password, but not the username.https://github.com/coleifer/peewee/blob/master/playhouse/db_url.py#L50
One possible solution is what is being requested in Issue #3179.
@tjbck commented on GitHub (Feb 19, 2025):
PR Welcome!
@bassettb commented on GitHub (Feb 20, 2025):
I'm adding the code to peewee
https://github.com/coleifer/peewee/pulls
@bassettb commented on GitHub (Feb 27, 2025):
Code was added to peewee. Just waiting for the maintainer to do a release.
I have an open-webui branch ready.