this is not actually a big deal but i was skimming trough the codebase working on another issue and saw an unnecesary double loop first to filter and then to present the <option>s, see image below.
Bug Summary:
this section of the code could be optimized with just a conditional
Steps to Reproduce:
src/lib/components/chat/Settings/Interface.svelte lines 194-198
Expected Behavior:
do just one iteration
Actual Behavior:
does two iterations
Environment
Operating System: Windows
Browser (if applicable): None
Reproduction Details
Confirmation:
I have read and followed all the instructions provided in the README.md.
I have reviewed the troubleshooting.md document.
I have included the browser console logs.
I have included the Docker container logs.
Logs and Screenshots
Browser Console Logs:
[Include relevant browser console logs, if applicable]
Docker Container Logs:
[Include relevant Docker container logs, if applicable]
Screenshots (if applicable):
Installation Method
none
Additional Information
none
Originally created by @Carlos-err406 on GitHub (Feb 29, 2024).
Original GitHub issue: https://github.com/open-webui/open-webui/issues/966
# Bug Report
## Description
this is not actually a big deal but i was skimming trough the codebase working on another issue and saw an unnecesary double loop first to filter and then to present the `<option>`s, see image below.
**Bug Summary:**
this section of the code could be optimized with just a conditional
**Steps to Reproduce:**
src/lib/components/chat/Settings/Interface.svelte lines 194-198
**Expected Behavior:**
do just one iteration
**Actual Behavior:**
does two iterations
## Environment
- **Operating System:** Windows
- **Browser (if applicable):** None
## Reproduction Details
**Confirmation:**
- [x] I have read and followed all the instructions provided in the README.md.
- [x] I have reviewed the troubleshooting.md document.
- [ ] I have included the browser console logs.
- [ ] I have included the Docker container logs.
## Logs and Screenshots
**Browser Console Logs:**
[Include relevant browser console logs, if applicable]
**Docker Container Logs:**
[Include relevant Docker container logs, if applicable]
**Screenshots (if applicable):**
## Installation Method
none
## Additional Information
none
@Carlos-err406 commented on GitHub (Feb 29, 2024):
i would like to open a PR for this if thats ok, already solved in a fork
<!-- gh-comment-id:1971632499 -->
@Carlos-err406 commented on GitHub (Feb 29, 2024):
i would like to open a PR for this if thats ok, already solved in a fork
@Carlos-err406 commented on GitHub (Feb 29, 2024):
i just found another loop like that one
<!-- gh-comment-id:1971900475 -->
@Carlos-err406 commented on GitHub (Feb 29, 2024):
i just found another loop like that one
in the end there were several (5 more) all of them addressed on #969 (^^")
<!-- gh-comment-id:1973349360 -->
@Carlos-err406 commented on GitHub (Mar 1, 2024):
in the end there were several (5 more) all of them addressed on #969 (^^")
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Originally created by @Carlos-err406 on GitHub (Feb 29, 2024).
Original GitHub issue: https://github.com/open-webui/open-webui/issues/966
Bug Report
Description
this is not actually a big deal but i was skimming trough the codebase working on another issue and saw an unnecesary double loop first to filter and then to present the
<option>s, see image below.Bug Summary:
this section of the code could be optimized with just a conditional
Steps to Reproduce:
src/lib/components/chat/Settings/Interface.svelte lines 194-198
Expected Behavior:
do just one iteration
Actual Behavior:
does two iterations
Environment
Reproduction Details
Confirmation:
Logs and Screenshots
Browser Console Logs:
[Include relevant browser console logs, if applicable]
Docker Container Logs:
[Include relevant Docker container logs, if applicable]
Screenshots (if applicable):
Installation Method
none
Additional Information
none
@Carlos-err406 commented on GitHub (Feb 29, 2024):
i would like to open a PR for this if thats ok, already solved in a fork
@Carlos-err406 commented on GitHub (Feb 29, 2024):
i just found another loop like that one
@Carlos-err406 commented on GitHub (Mar 1, 2024):
in the end there were several (5 more) all of them addressed on #969 (^^")