[PR #24953] fix: paginate model skills selector #131610

Open
opened 2026-05-21 17:18:58 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/24953
Author: @pragnyanramtha
Created: 5/20/2026
Status: 🔄 Open

Base: devHead: pragnyan/fix-model-skills-selector-pagination-24873


📝 Commits (1)

  • 510763b fix: paginate model skills selector

📊 Changes

1 file changed (+152 additions, -19 deletions)

View changed files

📝 src/lib/components/workspace/Models/SkillsSelector.svelte (+152 -19)

📄 Description

Pull Request Checklist

Before submitting, make sure you've checked the following:

  • Linked Issue/Discussion: This PR references an existing Issue or DiscussionCloses #24873.
  • Target branch: The pull request targets the dev branch. PRs targeting main will be immediately closed.
  • Description: Adds server-backed pagination and search to the model editor Skills selector so installations with more than 30 skills can select skills beyond the first API page.
  • Changelog: A changelog entry following Keep a Changelog format is included at the bottom.
  • Documentation: Not applicable; this is a focused UI bug fix and does not change documented behavior.
  • Dependencies: No new or updated dependencies.
  • Testing: Targeted formatting/lint/build checks were run. Full npm run check was attempted but the current repo state reports existing unrelated diagnostics across many files.
  • No Unchecked AI Code: The change was reviewed manually and by review agents before submission.
  • Self-Review: A self-review of the code has been performed, ensuring adherence to project coding standards.
  • Architecture: Uses existing Skills API pagination, existing Pagination UI, and local component state only.
  • Git Hygiene: The PR is atomic, based on dev, and contains no unrelated commits.
  • Title Prefix: The PR title uses the fix prefix.

Changelog Entry

Description

  • Fixes the Model Editor Skills selector so it can page and search through all skills instead of only showing the first 30 returned by the skills list API.
  • Keeps selected skills visible as removable chips when the user moves between pages or changes the search query.

Added

  • Paginated Skills selector controls in the model editor.
  • Search input for filtering skills through the existing /skills/list query path.

Changed

  • Skill selections are now tracked independently of the currently loaded page so cross-page selections are preserved.

Deprecated

  • N/A

Removed

  • N/A

Fixed

  • Model Editor skills selection being capped at the first 30 skills.
  • Hidden selected skills becoming difficult to review or remove after pagination/search changes.

Security

  • N/A

Breaking Changes

  • N/A

Additional Information

Validation performed:

  • npx prettier --plugin-search-dir --check src/lib/components/workspace/Models/SkillsSelector.svelte
  • npx eslint src/lib/components/workspace/Models/SkillsSelector.svelte
  • git diff --check
  • npm run build
  • npm run check was attempted; it currently fails in the repo with unrelated existing diagnostics across 383 files.

Screenshots or Videos

  • Not attached; this is a focused selector behavior fix and was validated with code review plus targeted frontend checks.

Contributor License Agreement

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/24953 **Author:** [@pragnyanramtha](https://github.com/pragnyanramtha) **Created:** 5/20/2026 **Status:** 🔄 Open **Base:** `dev` ← **Head:** `pragnyan/fix-model-skills-selector-pagination-24873` --- ### 📝 Commits (1) - [`510763b`](https://github.com/open-webui/open-webui/commit/510763b108ba88b91a288b8237516b30a4bfa3c5) fix: paginate model skills selector ### 📊 Changes **1 file changed** (+152 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/workspace/Models/SkillsSelector.svelte` (+152 -19) </details> ### 📄 Description # Pull Request Checklist **Before submitting, make sure you've checked the following:** - [x] **Linked Issue/Discussion:** This PR references an existing [Issue](https://github.com/open-webui/open-webui/issues) or [Discussion](https://github.com/open-webui/open-webui/discussions) — Closes #24873. - [x] **Target branch:** The pull request targets the `dev` branch. **PRs targeting `main` will be immediately closed.** - [x] **Description:** Adds server-backed pagination and search to the model editor Skills selector so installations with more than 30 skills can select skills beyond the first API page. - [x] **Changelog:** A changelog entry following [Keep a Changelog](https://keepachangelog.com/) format is included at the bottom. - [x] **Documentation:** Not applicable; this is a focused UI bug fix and does not change documented behavior. - [x] **Dependencies:** No new or updated dependencies. - [x] **Testing:** Targeted formatting/lint/build checks were run. Full `npm run check` was attempted but the current repo state reports existing unrelated diagnostics across many files. - [x] **No Unchecked AI Code:** The change was reviewed manually and by review agents before submission. - [x] **Self-Review:** A self-review of the code has been performed, ensuring adherence to project coding standards. - [x] **Architecture:** Uses existing Skills API pagination, existing `Pagination` UI, and local component state only. - [x] **Git Hygiene:** The PR is atomic, based on `dev`, and contains no unrelated commits. - [x] **Title Prefix:** The PR title uses the `fix` prefix. # Changelog Entry ### Description - Fixes the Model Editor Skills selector so it can page and search through all skills instead of only showing the first 30 returned by the skills list API. - Keeps selected skills visible as removable chips when the user moves between pages or changes the search query. ### Added - Paginated Skills selector controls in the model editor. - Search input for filtering skills through the existing `/skills/list` query path. ### Changed - Skill selections are now tracked independently of the currently loaded page so cross-page selections are preserved. ### Deprecated - N/A ### Removed - N/A ### Fixed - Model Editor skills selection being capped at the first 30 skills. - Hidden selected skills becoming difficult to review or remove after pagination/search changes. ### Security - N/A ### Breaking Changes - N/A --- ### Additional Information Validation performed: - `npx prettier --plugin-search-dir --check src/lib/components/workspace/Models/SkillsSelector.svelte` - `npx eslint src/lib/components/workspace/Models/SkillsSelector.svelte` - `git diff --check` - `npm run build` - `npm run check` was attempted; it currently fails in the repo with unrelated existing diagnostics across 383 files. ### Screenshots or Videos - Not attached; this is a focused selector behavior fix and was validated with code review plus targeted frontend checks. ### Contributor License Agreement <!-- 🚨 DO NOT DELETE THE TEXT BELOW 🚨 Keep the "Contributor License Agreement" confirmation text intact. Deleting it will trigger the CLA-Bot to INVALIDATE your PR. Your PR will NOT be reviewed or merged until you check the box below confirming that you have read and agree to the terms of the CLA. --> - [x] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-21 17:18:58 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#131610