[PR #24764] [MERGED] fix: check destination calendar write access on event update #131493

New Issue

GiteaMirror · 2026-05-21T17:03:55-05:00

GiteaMirror commented

2026-05-21 17:03:55 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/24764
Author: @Classic298
Created: 5/15/2026
Status: ✅ Merged
Merged: 5/19/2026
Merged by: @tjbck

Base: dev ← Head: fix/calendar-event-update-destination-authz

📝 Commits (1)

b43da8d fix: check destination calendar write access on event update

📊 Changes

1 file changed (+6 additions, -0 deletions)

View changed files

📝 backend/open_webui/routers/calendar.py (+6 -0)

📄 Description

update_event only verified write access on the event's source calendar. CalendarEventUpdateForm accepts a new calendar_id which the model layer applies unconditionally, so a user with write access to their own calendar could move (inject) an event into any other user's calendar. Mirror the destination check create_event already performs.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/24764 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 5/15/2026 **Status:** ✅ Merged **Merged:** 5/19/2026 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/calendar-event-update-destination-authz` --- ### 📝 Commits (1) - [`b43da8d`](https://github.com/open-webui/open-webui/commit/b43da8d6018874b7f64ac3a23b9116325d0483e9) fix: check destination calendar write access on event update ### 📊 Changes **1 file changed** (+6 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/calendar.py` (+6 -0) </details> ### 📄 Description update_event only verified write access on the event's source calendar. CalendarEventUpdateForm accepts a new calendar_id which the model layer applies unconditionally, so a user with write access to their own calendar could move (inject) an event into any other user's calendar. Mirror the destination check create_event already performs. ### Contributor License Agreement  - [x] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-21 17:03:55 -05:00

GiteaMirror closed this issue

2026-05-21 17:03:59 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#131493