[PR #24755] [MERGED] fix: respect access_type in shared-chat file authorization branch #131488

New Issue

GiteaMirror · 2026-05-21T17:03:26-05:00

GiteaMirror commented

2026-05-21 17:03:26 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/24755
Author: @Classic298
Created: 5/15/2026
Status: ✅ Merged
Merged: 5/19/2026
Merged by: @tjbck

Base: dev ← Head: fix/shared-chat-file-write-authz

📝 Commits (1)

1b53d4c fix: respect access_type in shared-chat file authorization branch

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 backend/open_webui/utils/access_control/files.py (+1 -1)

📄 Description

has_access_to_file granted access whenever the file was attached to a shared chat the user could read, ignoring the requested access_type. A read-only shared-chat recipient therefore satisfied write and delete checks and could delete or mutate the chat owner's attached file. Gate the shared-chat branch on read access, matching the channels branch directly above it.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/24755 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 5/15/2026 **Status:** ✅ Merged **Merged:** 5/19/2026 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/shared-chat-file-write-authz` --- ### 📝 Commits (1) - [`1b53d4c`](https://github.com/open-webui/open-webui/commit/1b53d4cbcf9772d8c482ba24eff1fc9d1a80e602) fix: respect access_type in shared-chat file authorization branch ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/utils/access_control/files.py` (+1 -1) </details> ### 📄 Description has_access_to_file granted access whenever the file was attached to a shared chat the user could read, ignoring the requested access_type. A read-only shared-chat recipient therefore satisfied write and delete checks and could delete or mutate the chat owner's attached file. Gate the shared-chat branch on read access, matching the channels branch directly above it. ### Contributor License Agreement  - [x] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-21 17:03:26 -05:00

GiteaMirror closed this issue

2026-05-21 17:03:30 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#131488