[PR #24729] [MERGED] fix: wire workspace.skills into the sidebar + workspace-index gates #131473

New Issue

GiteaMirror · 2026-05-21T17:01:58-05:00

GiteaMirror commented

2026-05-21 17:01:58 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/24729
Author: @Classic298
Created: 5/14/2026
Status: ✅ Merged
Merged: 5/15/2026
Merged by: @tjbck

Base: dev ← Head: fix/workspace-sidebar-skills-permission

📝 Commits (1)

8b6e3be fix: wire workspace.skills into the sidebar + workspace-index gates

📊 Changes

2 files changed (+4 additions, -1 deletions)

View changed files

📝 src/lib/components/layout/Sidebar.svelte (+2 -1)
📝 src/routes/(app)/workspace/+page.svelte (+2 -0)

📄 Description

Reported by bwgabrielsusai on #24719: granting a user only workspace.skills doesn't show the Workspace menu, and visiting /workspace directly bounces them to /.

The per-route guard in /workspace/+layout.svelte already covered skills, but two earlier gates in the chain didn't:

Sidebar.svelte case 'workspace' OR'd models/knowledge/prompts/tools to decide menu visibility — skills was missing, so the entry never rendered for skills-only users.
/workspace/+page.svelte redirect chain picked the first available section — skills was missing, so the fallback goto('/') fired.

Adding skills to both.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/24729 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 5/14/2026 **Status:** ✅ Merged **Merged:** 5/15/2026 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/workspace-sidebar-skills-permission` --- ### 📝 Commits (1) - [`8b6e3be`](https://github.com/open-webui/open-webui/commit/8b6e3befc50b1b839955b8f24afdba73c87c6b8d) fix: wire workspace.skills into the sidebar + workspace-index gates ### 📊 Changes **2 files changed** (+4 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/layout/Sidebar.svelte` (+2 -1) 📝 `src/routes/(app)/workspace/+page.svelte` (+2 -0) </details> ### 📄 Description Reported by bwgabrielsusai on #24719: granting a user only `workspace.skills` doesn't show the Workspace menu, and visiting `/workspace` directly bounces them to `/`. The per-route guard in `/workspace/+layout.svelte` already covered skills, but two earlier gates in the chain didn't: * `Sidebar.svelte` case 'workspace' OR'd models/knowledge/prompts/tools to decide menu visibility — skills was missing, so the entry never rendered for skills-only users. * `/workspace/+page.svelte` redirect chain picked the first available section — skills was missing, so the fallback `goto('/')` fired. Adding skills to both. ### Contributor License Agreement  - [x] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-21 17:01:59 -05:00

GiteaMirror closed this issue

2026-05-21 17:02:02 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#131473