[PR #24555] [CLOSED] fix: prevent details leak from edited assistant content #131388

New Issue

GiteaMirror · 2026-05-21T16:48:46-05:00

GiteaMirror commented

2026-05-21 16:48:46 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/24555
Author: @Algorithm5838
Created: 5/10/2026
Status: ❌ Closed

Base: dev ← Head: fix/details-leak-on-edit

📝 Commits (1)

0aca87c fix: prevent details leak from edited assistant content

📊 Changes

2 files changed (+39 additions, -9 deletions)

View changed files

📝 backend/open_webui/models/chats.py (+39 -0)
📝 backend/open_webui/routers/chats.py (+0 -9)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request.

This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR.

Before submitting, make sure you've checked the following:

Linked Issue/Discussion: This PR references an existing Issue or Discussion — Closes #___ / Relates to #___. If one does not exist, create one first. PRs without a linked issue or discussion may be closed without review.
Target branch: Verify that the pull request targets the dev branch. PRs targeting main will be immediately closed.
Description: Provide a concise description of the changes made in this pull request down below.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Add docs in Open WebUI Docs Repository. Document user-facing behavior, environment variables, public APIs/interfaces, or deployment steps.
Dependencies: Are there any new or upgraded dependencies? If so, explain why, update the changelog/docs, and include any compatibility notes. Actually run the code/function that uses updated library to ensure it doesn't crash.
Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Include reproducible steps to demonstrate the issue before the fix. Test edge cases (URL encoding, HTML entities, types). Take this as an opportunity to make screenshots of the feature/fix and include them in the PR description.
Agentic AI Code: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review AND manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Design & Architecture: Prefer smart defaults over adding new settings; use local state for ephemeral UI logic. Open a Discussion for major architectural or UX changes.
Git Hygiene: Keep PRs atomic (one logical change). Clean up commits and rebase on dev to ensure no unrelated commits (e.g. from main) are included. Push updates to the existing PR branch instead of closing and reopening.
Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Deleting a reasoning or tool block in the structured editor updates output but leaves content with the stale <details> HTML. On the next turn, backend paths that fall back to content still pass the deleted block to the LLM. The symmetric case: an outlet Filter (e.g. "Remove Thinking") that strips <details> from content is undone on the next save, because the router endpoint unconditionally rewrote content = serialize_output(output) before persisting.

To reproduce (editor):

Enable a tool on a model and send a message that triggers it.
Open the structured editor and remove the tool call block.
Send another message.
The deleted block is still sent to the AI.

To reproduce (filter):

Install an outlet Filter that strips <details> blocks from content.
Generate a reasoning response. The block is hidden.
Refresh the page once. Still hidden.
Refresh again. The block is back.

Root cause: the structured editor updates output only, and the save path doesn't reconcile content against it. The router-side rewrite that did exist was too aggressive and overwrote intentional content edits.

Added

[List any new features, functionalities, or additions]

Changed

[List any changes, updates, refactorings, or optimizations]

Deprecated

[List any deprecated functionality or features that have been removed]

Removed

[List any removed features, files, or functionalities]

Fixed

In update_chat_by_id (models): rewrite content = serialize_output(output) when output changes. Skip if content also changed, or if the prior content didn't match serialize_output(prior_output). This preserves filter outlet rewrites and manual edits.
In update_chat_by_id (router): remove the unconditional pre-save rewrite of content from output, so the model-layer guard is the single decision point.

Security

[List any new or updated security-related changes, including vulnerability fixes]

Breaking Changes

BREAKING CHANGE: [List any breaking changes affecting compatibility or functionality]

Additional Information

The rewrite is diff-aware: only messages whose output changed are rewritten. Messages without output are skipped, preserving plain text edits and legacy chats.

Screenshots or Videos

[Attach any relevant screenshots or videos demonstrating the changes]

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/24555 **Author:** [@Algorithm5838](https://github.com/Algorithm5838) **Created:** 5/10/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/details-leak-on-edit` --- ### 📝 Commits (1) - [`0aca87c`](https://github.com/open-webui/open-webui/commit/0aca87c58bccaeb46348f47df94ddecf7936b347) fix: prevent details leak from edited assistant content ### 📊 Changes **2 files changed** (+39 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/models/chats.py` (+39 -0) 📝 `backend/open_webui/routers/chats.py` (+0 -9) </details> ### 📄 Description  # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request. This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR.  **Before submitting, make sure you've checked the following:** - [ ] **Linked Issue/Discussion:** This PR references an existing [Issue](https://github.com/open-webui/open-webui/issues) or [Discussion](https://github.com/open-webui/open-webui/discussions) — `Closes #___` / `Relates to #___`. If one does not exist, create one first. PRs without a linked issue or discussion may be closed without review. - [x] **Target branch:** Verify that the pull request targets the `dev` branch. **PRs targeting `main` will be immediately closed.** - [x] **Description:** Provide a concise description of the changes made in this pull request down below. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Add docs in [Open WebUI Docs Repository](https://github.com/open-webui/docs). Document user-facing behavior, environment variables, public APIs/interfaces, or deployment steps. - [x] **Dependencies:** Are there any new or upgraded dependencies? If so, explain why, update the changelog/docs, and include any compatibility notes. Actually run the code/function that uses updated library to ensure it doesn't crash. - [x] **Testing:** Perform manual tests to **verify the implemented fix/feature works as intended AND does not break any other functionality**. Include reproducible steps to demonstrate the issue before the fix. Test edge cases (URL encoding, HTML entities, types). Take this as an opportunity to **make screenshots of the feature/fix and include them in the PR description**. - [x] **Agentic AI Code:** Confirm this Pull Request is **not written by any AI Agent** or has at least **gone through additional human review AND manual testing**. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Design & Architecture:** Prefer smart defaults over adding new settings; use local state for ephemeral UI logic. Open a Discussion for major architectural or UX changes. - [x] **Git Hygiene:** Keep PRs atomic (one logical change). Clean up commits and rebase on `dev` to ensure no unrelated commits (e.g. from `main`) are included. Push updates to the existing PR branch instead of closing and reopening. - [x] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description Deleting a reasoning or tool block in the structured editor updates `output` but leaves `content` with the stale `<details>` HTML. On the next turn, backend paths that fall back to `content` still pass the deleted block to the LLM. The symmetric case: an outlet `Filter` (e.g. "Remove Thinking") that strips `<details>` from `content` is undone on the next save, because the router endpoint unconditionally rewrote `content = serialize_output(output)` before persisting. To reproduce (editor): 1. Enable a tool on a model and send a message that triggers it. 2. Open the structured editor and remove the tool call block. 3. Send another message. 4. The deleted block is still sent to the AI. To reproduce (filter): 1. Install an outlet `Filter` that strips `<details>` blocks from `content`. 2. Generate a reasoning response. The block is hidden. 3. Refresh the page once. Still hidden. 4. Refresh again. The block is back. Root cause: the structured editor updates `output` only, and the save path doesn't reconcile `content` against it. The router-side rewrite that did exist was too aggressive and overwrote intentional content edits. ### Added - [List any new features, functionalities, or additions] ### Changed - [List any changes, updates, refactorings, or optimizations] ### Deprecated - [List any deprecated functionality or features that have been removed] ### Removed - [List any removed features, files, or functionalities] ### Fixed - In `update_chat_by_id` (models): rewrite `content = serialize_output(output)` when `output` changes. Skip if `content` also changed, or if the prior `content` didn't match `serialize_output(prior_output)`. This preserves filter `outlet` rewrites and manual edits. - In `update_chat_by_id` (router): remove the unconditional pre-save rewrite of `content` from `output`, so the model-layer guard is the single decision point. ### Security - [List any new or updated security-related changes, including vulnerability fixes] ### Breaking Changes - **BREAKING CHANGE**: [List any breaking changes affecting compatibility or functionality] --- ### Additional Information - The rewrite is diff-aware: only messages whose `output` changed are rewritten. Messages without `output` are skipped, preserving plain text edits and legacy chats. ### Screenshots or Videos - [Attach any relevant screenshots or videos demonstrating the changes] ### Contributor License Agreement  - [x] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-21 16:48:46 -05:00

GiteaMirror closed this issue

2026-05-21 16:48:52 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#131388