github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-07-16 06:03:26 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #24523] [CLOSED] feat: Add contextual MCP/tool-server file upload allowlists #131371

New Issue
Closed
opened 2026-05-21 16:46:42 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-21 16:46:42 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/24523
Author: @icsy7867
Created: 5/9/2026
Status: ❌ Closed

Base: dev ← Head: dev-mcp-file-allowlist

📝 Commits (7)

  • bbda6b8 Allow MCP tool servers to accept configured file types
  • a496f61 Prefer MCP file allowlists over built-in STT
  • 907c16c Let MCP file allowlists bypass built-in processing
  • 9dd6977 Respect disabled chat tools for file allowlists
  • 3eb1d60 Update translations for MIME type allowlist label
  • de8ff55 chore: format tool server modal
  • 2f6419e chore: format files router

📊 Changes

66 files changed (+284 additions, -9 deletions)

View changed files

📝 backend/open_webui/routers/files.py (+127 -1)
📝 src/lib/apis/files/index.ts (+8 -3)
📝 src/lib/components/AddToolServerModal.svelte (+68 -2)
📝 src/lib/components/chat/Chat.svelte (+5 -1)
📝 src/lib/components/chat/MessageInput.svelte (+15 -2)
📝 src/lib/i18n/locales/ar-BH/translation.json (+1 -0)
📝 src/lib/i18n/locales/ar/translation.json (+1 -0)
📝 src/lib/i18n/locales/az-AZ/translation.json (+1 -0)
📝 src/lib/i18n/locales/bg-BG/translation.json (+1 -0)
📝 src/lib/i18n/locales/bn-BD/translation.json (+1 -0)
📝 src/lib/i18n/locales/bo-TB/translation.json (+1 -0)
📝 src/lib/i18n/locales/bs-BA/translation.json (+1 -0)
📝 src/lib/i18n/locales/ca-ES/translation.json (+1 -0)
📝 src/lib/i18n/locales/ceb-PH/translation.json (+1 -0)
📝 src/lib/i18n/locales/cs-CZ/translation.json (+1 -0)
📝 src/lib/i18n/locales/da-DK/translation.json (+1 -0)
📝 src/lib/i18n/locales/de-DE/translation.json (+1 -0)
📝 src/lib/i18n/locales/dg-DG/translation.json (+1 -0)
📝 src/lib/i18n/locales/el-GR/translation.json (+1 -0)
📝 src/lib/i18n/locales/en-GB/translation.json (+1 -0)

...and 46 more files

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request.

This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR.

Before submitting, make sure you've checked the following:

  • Target branch: Verify that the pull request targets the dev branch. PRs targeting main will be immediately closed.
  • Description: Provide a concise description of the changes made in this pull request down below.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Add docs in Open WebUI Docs Repository. Document user-facing behavior, environment variables, public APIs/interfaces, or deployment steps.
  • Dependencies: Are there any new or upgraded dependencies? If so, explain why, update the changelog/docs, and include any compatibility notes. Actually run the code/function that uses updated library to ensure it doesn't crash.
  • Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Include reproducible steps to demonstrate the issue before the fix. Test edge cases (URL encoding, HTML entities, types). Take this as an opportunity to make screenshots of the feature/fix and include them in the PR description.
  • Agentic AI Code: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review AND manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Design & Architecture: Prefer smart defaults over adding new settings; use local state for ephemeral UI logic. Open a Discussion for major architectural or UX changes.
  • Git Hygiene: Keep PRs atomic (one logical change). Clean up commits and rebase on dev to ensure no unrelated commits (e.g. from main) are included. Push updates to the existing PR branch instead of closing and reopening.
  • Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

This PR adds optional per-tool-server file extension and MIME type allowlists so MCP/OpenAPI tool integrations can accept files that would
otherwise be handled or rejected by Open WebUI’s built-in processing paths.

This is useful for tool servers that own specialized file workflows, such as audio diarization/transcription, PDF processing, media
analysis, or other file-specific integrations.

Why
Previously, file admission and processing were tightly coupled to built-in Open WebUI capabilities. For example, audio uploads were coupled
to built-in STT settings, which made it difficult to build MCP tools that process audio independently.

This PR lets a configured and active tool integration declare ownership of specific file types without requiring unrelated core features to
be enabled or bypassed globally.

Added

  • Added file_extensions and mime_types fields to tool-server connection config.
  • Added UI inputs for these fields in the tool-server admin modal.
  • Included current upload context from chat uploads:
    • active chat ID
    • selected model IDs
    • currently enabled tool IDs
  • Backend now checks whether an uploaded file matches an active tool server’s declared allowlist.
  • Matching files are stored and marked completed without running built-in processing.
  • Built-in STT/document parsing still runs when no active tool-server allowlist matches.
  • Explicit per-chat tool selection is respected:
    • enabled tool: allowlist applies
    • disabled tool: allowlist does not apply, even if the model preset includes the tool
Screenshot 2026-05-09 170447

As an example, a sample mp3 file I found on the internet, even if my STT MCP Integration is added in the Admin Settings, but disabled for a model, the original Audio pipeline re-engages:

Screenshot 2026-05-09 170508

When I enable my MCP Integration, with an mp3 file extension listed, my audio file uploads, bypasses the audio pipeline and no toast errors appear:

Screenshot 2026-05-09 170528

Changed

  • [List any changes, updates, refactorings, or optimizations]

Deprecated

  • [List any deprecated functionality or features that have been removed]

Removed

  • [List any removed features, files, or functionalities]

Fixed

  • [List any fixes, corrections, or bug fixes]

Security

  • [List any new or updated security-related changes, including vulnerability fixes]

Breaking Changes

  • BREAKING CHANGE: [List any breaking changes affecting compatibility or functionality]

Additional Information

As always, thank you for such an amazing tool!

Screenshots or Videos

  • [Attach any relevant screenshots or videos demonstrating the changes]

Contributor License Agreement

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/24523 **Author:** [@icsy7867](https://github.com/icsy7867) **Created:** 5/9/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `dev-mcp-file-allowlist` --- ### 📝 Commits (7) - [`bbda6b8`](https://github.com/open-webui/open-webui/commit/bbda6b84839b60622dc9a24107d38c63a7396363) Allow MCP tool servers to accept configured file types - [`a496f61`](https://github.com/open-webui/open-webui/commit/a496f61903de6b28e98158008a5f3b5768d89873) Prefer MCP file allowlists over built-in STT - [`907c16c`](https://github.com/open-webui/open-webui/commit/907c16c648e9a6c074c209340f8e1683bf8724c0) Let MCP file allowlists bypass built-in processing - [`9dd6977`](https://github.com/open-webui/open-webui/commit/9dd69777605f67a569cde0cd8620b4dd6886adfa) Respect disabled chat tools for file allowlists - [`3eb1d60`](https://github.com/open-webui/open-webui/commit/3eb1d604f9053c54378a402c1c193e0159ecadb4) Update translations for MIME type allowlist label - [`de8ff55`](https://github.com/open-webui/open-webui/commit/de8ff5563de7c822b69575ac061568827cbc82f7) chore: format tool server modal - [`2f6419e`](https://github.com/open-webui/open-webui/commit/2f6419e3c04ba27428e77dddea9b6015f7e2461d) chore: format files router ### 📊 Changes **66 files changed** (+284 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/files.py` (+127 -1) 📝 `src/lib/apis/files/index.ts` (+8 -3) 📝 `src/lib/components/AddToolServerModal.svelte` (+68 -2) 📝 `src/lib/components/chat/Chat.svelte` (+5 -1) 📝 `src/lib/components/chat/MessageInput.svelte` (+15 -2) 📝 `src/lib/i18n/locales/ar-BH/translation.json` (+1 -0) 📝 `src/lib/i18n/locales/ar/translation.json` (+1 -0) 📝 `src/lib/i18n/locales/az-AZ/translation.json` (+1 -0) 📝 `src/lib/i18n/locales/bg-BG/translation.json` (+1 -0) 📝 `src/lib/i18n/locales/bn-BD/translation.json` (+1 -0) 📝 `src/lib/i18n/locales/bo-TB/translation.json` (+1 -0) 📝 `src/lib/i18n/locales/bs-BA/translation.json` (+1 -0) 📝 `src/lib/i18n/locales/ca-ES/translation.json` (+1 -0) 📝 `src/lib/i18n/locales/ceb-PH/translation.json` (+1 -0) 📝 `src/lib/i18n/locales/cs-CZ/translation.json` (+1 -0) 📝 `src/lib/i18n/locales/da-DK/translation.json` (+1 -0) 📝 `src/lib/i18n/locales/de-DE/translation.json` (+1 -0) 📝 `src/lib/i18n/locales/dg-DG/translation.json` (+1 -0) 📝 `src/lib/i18n/locales/el-GR/translation.json` (+1 -0) 📝 `src/lib/i18n/locales/en-GB/translation.json` (+1 -0) _...and 46 more files_ </details> ### 📄 Description <!-- ⚠️ CRITICAL CHECKS FOR CONTRIBUTORS (READ, DON'T DELETE) ⚠️ 1. Target the `dev` branch. PRs targeting `main` will be automatically closed. 2. Do NOT delete the CLA section at the bottom. It is required for the bot to accept your PR. --> # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request. This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR. <!-- ### ⚠️ Important: Your PR is a contribution, not a guarantee of merge. The most impactful way to contribute to Open WebUI is through well-written bug reports, detailed feature discussions, and thoughtful ideas. These directly shape the project. If you do open a pull request, please know that Open WebUI is held to the highest standard of code quality, consistency, and architectural coherence, and every line merged becomes something the core team must own, maintain, and support indefinitely. Submitted code may be refactored, rewritten, or used as inspiration for a different implementation. This is not a reflection of your work's quality. It is how we ensure that a small team can deeply understand and evolve every part of the codebase. --> **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Verify that the pull request targets the `dev` branch. **PRs targeting `main` will be immediately closed.** - [x] **Description:** Provide a concise description of the changes made in this pull request down below. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Add docs in [Open WebUI Docs Repository](https://github.com/open-webui/docs). Document user-facing behavior, environment variables, public APIs/interfaces, or deployment steps. - [x] **Dependencies:** Are there any new or upgraded dependencies? If so, explain why, update the changelog/docs, and include any compatibility notes. Actually run the code/function that uses updated library to ensure it doesn't crash. - [x] **Testing:** Perform manual tests to **verify the implemented fix/feature works as intended AND does not break any other functionality**. Include reproducible steps to demonstrate the issue before the fix. Test edge cases (URL encoding, HTML entities, types). Take this as an opportunity to **make screenshots of the feature/fix and include them in the PR description**. - [x] **Agentic AI Code:** Confirm this Pull Request is **not written by any AI Agent** or has at least **gone through additional human review AND manual testing**. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Design & Architecture:** Prefer smart defaults over adding new settings; use local state for ephemeral UI logic. Open a Discussion for major architectural or UX changes. - [x] **Git Hygiene:** Keep PRs atomic (one logical change). Clean up commits and rebase on `dev` to ensure no unrelated commits (e.g. from `main`) are included. Push updates to the existing PR branch instead of closing and reopening. - [x] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description This PR adds optional per-tool-server file extension and MIME type allowlists so MCP/OpenAPI tool integrations can accept files that would otherwise be handled or rejected by Open WebUI’s built-in processing paths. This is useful for tool servers that own specialized file workflows, such as audio diarization/transcription, PDF processing, media analysis, or other file-specific integrations. **Why** Previously, file admission and processing were tightly coupled to built-in Open WebUI capabilities. For example, audio uploads were coupled to built-in STT settings, which made it difficult to build MCP tools that process audio independently. This PR lets a configured and active tool integration declare ownership of specific file types without requiring unrelated core features to be enabled or bypassed globally. ### Added - Added file_extensions and mime_types fields to tool-server connection config. - Added UI inputs for these fields in the tool-server admin modal. - Included current upload context from chat uploads: - active chat ID - selected model IDs - currently enabled tool IDs - Backend now checks whether an uploaded file matches an active tool server’s declared allowlist. - Matching files are stored and marked completed without running built-in processing. - Built-in STT/document parsing still runs when no active tool-server allowlist matches. - Explicit per-chat tool selection is respected: - enabled tool: allowlist applies - disabled tool: allowlist does not apply, even if the model preset includes the tool <img width="491" height="586" alt="Screenshot 2026-05-09 170447" src="https://github.com/user-attachments/assets/487f8740-5b42-47d9-bf87-e944fdf999e9" /> As an example, a sample mp3 file I found on the internet, even if my STT MCP Integration is added in the Admin Settings, but disabled for a model, the original Audio pipeline re-engages: <img width="1079" height="314" alt="Screenshot 2026-05-09 170508" src="https://github.com/user-attachments/assets/00b4046f-6daf-4e84-bfe3-7c6aa34a4966" /> When I enable my MCP Integration, with an mp3 file extension listed, my audio file uploads, bypasses the audio pipeline and no toast errors appear: <img width="1054" height="361" alt="Screenshot 2026-05-09 170528" src="https://github.com/user-attachments/assets/dcb7ccab-e9c9-4ea8-86dd-03f91fcf9a1d" /> ### Changed - [List any changes, updates, refactorings, or optimizations] ### Deprecated - [List any deprecated functionality or features that have been removed] ### Removed - [List any removed features, files, or functionalities] ### Fixed - [List any fixes, corrections, or bug fixes] ### Security - [List any new or updated security-related changes, including vulnerability fixes] ### Breaking Changes - **BREAKING CHANGE**: [List any breaking changes affecting compatibility or functionality] --- ### Additional Information As always, thank you for such an amazing tool! ### Screenshots or Videos - [Attach any relevant screenshots or videos demonstrating the changes] ### Contributor License Agreement <!-- 🚨 DO NOT DELETE THE TEXT BELOW 🚨 Keep the "Contributor License Agreement" confirmation text intact. Deleting it will trigger the CLA-Bot to INVALIDATE your PR. Your PR will NOT be reviewed or merged until you check the box below confirming that you have read and agree to the terms of the CLA. --> - [x] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-21 16:46:42 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#131371
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?