github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-07-16 14:39:31 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #24387] [CLOSED] fix: prevent stored XSS via tool_calls details in channel messages #131300

New Issue
Closed
opened 2026-05-21 16:38:13 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-21 16:38:13 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/24387
Author: @Classic298
Created: 5/5/2026
Status: ❌ Closed

Base: dev ← Head: fix/stored-xss-channel-messages

📝 Commits (1)

  • 3659ff9 fix: prevent stored XSS via tool_calls details in channel messages

📊 Changes

5 files changed (+40 additions, -1 deletions)

View changed files

📝 backend/open_webui/routers/channels.py (+25 -0)
📝 src/lib/components/channel/Messages/Message.svelte (+2 -0)
📝 src/lib/components/chat/Messages/Markdown.svelte (+3 -0)
📝 src/lib/components/chat/Messages/Markdown/ConsecutiveDetailsGroup.svelte (+7 -1)
📝 src/lib/components/chat/Messages/Markdown/MarkdownTokens.svelte (+3 -0)

📄 Description

Channel messages are user-authored and must never reach the allow-scripts iframe path used for assistant tool-call rendering.

Frontend: thread an untrustedSource flag from channel Message.svelte through Markdown -> MarkdownTokens -> ConsecutiveDetailsGroup. When true, allEmbeds is forced to an empty array, skipping iframe rendering entirely. Assistant chat messages are unaffected (default is false).

Backend (defense-in-depth): strip

blocks from channel message content in new_message_handler and update_message_by_id before persistence.

Contributor License Agreement

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/24387 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 5/5/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/stored-xss-channel-messages` --- ### 📝 Commits (1) - [`3659ff9`](https://github.com/open-webui/open-webui/commit/3659ff9267cc65e204731c0ad4c1d908b055817c) fix: prevent stored XSS via tool_calls details in channel messages ### 📊 Changes **5 files changed** (+40 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/channels.py` (+25 -0) 📝 `src/lib/components/channel/Messages/Message.svelte` (+2 -0) 📝 `src/lib/components/chat/Messages/Markdown.svelte` (+3 -0) 📝 `src/lib/components/chat/Messages/Markdown/ConsecutiveDetailsGroup.svelte` (+7 -1) 📝 `src/lib/components/chat/Messages/Markdown/MarkdownTokens.svelte` (+3 -0) </details> ### 📄 Description Channel messages are user-authored and must never reach the allow-scripts iframe path used for assistant tool-call rendering. Frontend: thread an untrustedSource flag from channel Message.svelte through Markdown -> MarkdownTokens -> ConsecutiveDetailsGroup. When true, allEmbeds is forced to an empty array, skipping iframe rendering entirely. Assistant chat messages are unaffected (default is false). Backend (defense-in-depth): strip <details type=tool_calls> blocks from channel message content in new_message_handler and update_message_by_id before persistence. ### Contributor License Agreement <!-- 🚨 DO NOT DELETE THE TEXT BELOW 🚨 Keep the "Contributor License Agreement" confirmation text intact. Deleting it will trigger the CLA-Bot to INVALIDATE your PR. Your PR will NOT be reviewed or merged until you check the box below confirming that you have read and agree to the terms of the CLA. --> - [X] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-21 16:38:13 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#131300
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?