[PR #23905] [CLOSED] feat: enhance Shared Chats management with bulk actions and persistent selection #131100

New Issue

2026-05-21T16:08:09-05:00

GiteaMirror commented

2026-05-21 16:08:09 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/23905
Author: @wyyy1218
Created: 4/21/2026
Status: ❌ Closed

Base: dev ← Head: feat/shared-chats-management-batch-revoke

📝 Commits (4)

64161eb feat: enhance shared chats management APIs
f862e53 feat: add shared chats dashboard UI and store integration
35c3c07 test: add shared chats count and bulk revoke coverage
a083a9f fix: address review feedback for shared chats modal and batch revoke

📊 Changes

9 files changed (+1119 additions, -89 deletions)

View changed files

📝 backend/open_webui/routers/chats.py (+83 -2)
➕ backend/open_webui/test/apps/webui/routers/test_chats.py (+265 -0)
➕ backend/open_webui/test/conftest.py (+41 -0)
➕ backend/open_webui/test/util/abstract_integration_test.py (+186 -0)
➕ backend/open_webui/test/util/mock_user.py (+74 -0)
📝 src/lib/apis/chats/index.ts (+73 -0)
📝 src/lib/components/layout/SharedChatsModal.svelte (+184 -87)
➕ src/lib/components/layout/SharedChatsTable.svelte (+171 -0)
➕ src/lib/stores/sharedChats.ts (+42 -0)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request.

This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR.

Before submitting, make sure you've checked the following:

Target branch: Verify that the pull request targets the dev branch. PRs targeting main will be immediately closed.
Description: Provide a concise description of the changes made in this pull request down below.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Add docs in Open WebUI Docs Repository. Document user-facing behavior, environment variables, public APIs/interfaces, or deployment steps.
Dependencies: Are there any new or upgraded dependencies? If so, explain why, update the changelog/docs, and include any compatibility notes. Actually run the code/function that uses updated library to ensure it doesn't crash.
Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Include reproducible steps to demonstrate the issue before the fix. Test edge cases (URL encoding, HTML entities, types). Take this as an opportunity to make screenshots of the feature/fix and include them in the PR description.
Agentic AI Code: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review AND manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Design & Architecture: Prefer smart defaults over adding new settings; use local state for ephemeral UI logic. Open a Discussion for major architectural or UX changes.
Git Hygiene: Keep PRs atomic (one logical change). Clean up commits and rebase on dev to ensure no unrelated commits (e.g. from main) are included. Push updates to the existing PR branch instead of closing and reopening.
Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

This PR enhances the existing Shared Chats management flow with focused dashboard capabilities: multi-selection, bulk unshare, persistent selection across page navigation, Created at sorting, and clearer management feedback.
The backend is extended with minimal required APIs (shared/count, shared/revoke) while preserving existing sharing behavior and keeping scope tightly aligned to the management workflow.

Added

Shared chats count endpoint: GET /api/v1/chats/shared/count
Shared chats batch revoke endpoint: POST /api/v1/chats/shared/revoke
Frontend API wrappers: getSharedChatListV2, getSharedChatsCount, revokeSharedChatsBatch
Shared chats dashboard table component with row selection and page-level selection
Shared chats selection store for persistent selected IDs across page changes
Router integration tests covering count/sort/batch revoke/cross-page behavior

Changed

Shared chats page size is aligned to 20 for dashboard pagination behavior
Shared chats modal flow is upgraded to:
- show Total and Selected counters
- support bulk unshare for selected entries
- keep selection state when moving between pages
- support Created at sort option in addition to existing sort controls
Empty-state and no-result feedback are made explicit in the shared chats UI

Deprecated

None

Removed

None

Fixed

Fixed inability to manage many shared links efficiently due to missing batch operation support
Fixed lack of consistent count feedback after selection and revoke operations
Fixed missing management pathway for Created at ordering in the Shared Chats dashboard context

Security

No security-sensitive behavior changes
No new secrets, credentials, or permission model changes introduced

Breaking Changes

BREAKING CHANGE: None

Additional Information

Scope intentionally excludes password-protected links, expiration controls, QR generation, custom slug, and permission-system redesign.
No new dependencies were introduced.
Backend verification command:
- pytest -q backend/open_webui/test/apps/webui/routers/test_chats.py
Test result summary:
- 9 passed

Screenshots or Videos

Shared chats overview: management modal with list, counters, search box, sort headers, and actions
Multi-select with total/selected counters: row-level and page-level selections reflected in header counters
Bulk unshare workflow: selected shared chats revoked in one action
Created at sorting behavior: ordering of rows after Created at sort toggle
Empty and no-result states: clear feedback for no shared chats and no search match cases

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/23905 **Author:** [@wyyy1218](https://github.com/wyyy1218) **Created:** 4/21/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `feat/shared-chats-management-batch-revoke` --- ### 📝 Commits (4) - [`64161eb`](https://github.com/open-webui/open-webui/commit/64161eb2cf892b39158b9b9a404e0636a0bd9b8d) feat: enhance shared chats management APIs - [`f862e53`](https://github.com/open-webui/open-webui/commit/f862e53aed33408d026fc28ccda25632e8488102) feat: add shared chats dashboard UI and store integration - [`35c3c07`](https://github.com/open-webui/open-webui/commit/35c3c074fb915f60a218459f16287bb1e0619c08) test: add shared chats count and bulk revoke coverage - [`a083a9f`](https://github.com/open-webui/open-webui/commit/a083a9fd159faec43261587c36d759165a4b1fc1) fix: address review feedback for shared chats modal and batch revoke ### 📊 Changes **9 files changed** (+1119 additions, -89 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/chats.py` (+83 -2) ➕ `backend/open_webui/test/apps/webui/routers/test_chats.py` (+265 -0) ➕ `backend/open_webui/test/conftest.py` (+41 -0) ➕ `backend/open_webui/test/util/abstract_integration_test.py` (+186 -0) ➕ `backend/open_webui/test/util/mock_user.py` (+74 -0) 📝 `src/lib/apis/chats/index.ts` (+73 -0) 📝 `src/lib/components/layout/SharedChatsModal.svelte` (+184 -87) ➕ `src/lib/components/layout/SharedChatsTable.svelte` (+171 -0) ➕ `src/lib/stores/sharedChats.ts` (+42 -0) </details> ### 📄 Description  # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request. This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Verify that the pull request targets the `dev` branch. **PRs targeting `main` will be immediately closed.** - [x] **Description:** Provide a concise description of the changes made in this pull request down below. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Add docs in [Open WebUI Docs Repository](https://github.com/open-webui/docs). Document user-facing behavior, environment variables, public APIs/interfaces, or deployment steps. - [x] **Dependencies:** Are there any new or upgraded dependencies? If so, explain why, update the changelog/docs, and include any compatibility notes. Actually run the code/function that uses updated library to ensure it doesn't crash. - [x] **Testing:** Perform manual tests to **verify the implemented fix/feature works as intended AND does not break any other functionality**. Include reproducible steps to demonstrate the issue before the fix. Test edge cases (URL encoding, HTML entities, types). Take this as an opportunity to **make screenshots of the feature/fix and include them in the PR description**. - [x] **Agentic AI Code:** Confirm this Pull Request is **not written by any AI Agent** or has at least **gone through additional human review AND manual testing**. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Design & Architecture:** Prefer smart defaults over adding new settings; use local state for ephemeral UI logic. Open a Discussion for major architectural or UX changes. - [x] **Git Hygiene:** Keep PRs atomic (one logical change). Clean up commits and rebase on `dev` to ensure no unrelated commits (e.g. from `main`) are included. Push updates to the existing PR branch instead of closing and reopening. - [x] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - This PR enhances the existing Shared Chats management flow with focused dashboard capabilities: multi-selection, bulk unshare, persistent selection across page navigation, `Created at` sorting, and clearer management feedback. - The backend is extended with minimal required APIs (`shared/count`, `shared/revoke`) while preserving existing sharing behavior and keeping scope tightly aligned to the management workflow. ### Added - Shared chats count endpoint: `GET /api/v1/chats/shared/count` - Shared chats batch revoke endpoint: `POST /api/v1/chats/shared/revoke` - Frontend API wrappers: `getSharedChatListV2`, `getSharedChatsCount`, `revokeSharedChatsBatch` - Shared chats dashboard table component with row selection and page-level selection - Shared chats selection store for persistent selected IDs across page changes - Router integration tests covering count/sort/batch revoke/cross-page behavior ### Changed - Shared chats page size is aligned to 20 for dashboard pagination behavior - Shared chats modal flow is upgraded to: - show `Total` and `Selected` counters - support bulk unshare for selected entries - keep selection state when moving between pages - support `Created at` sort option in addition to existing sort controls - Empty-state and no-result feedback are made explicit in the shared chats UI ### Deprecated - None ### Removed - None ### Fixed - Fixed inability to manage many shared links efficiently due to missing batch operation support - Fixed lack of consistent count feedback after selection and revoke operations - Fixed missing management pathway for `Created at` ordering in the Shared Chats dashboard context ### Security - No security-sensitive behavior changes - No new secrets, credentials, or permission model changes introduced ### Breaking Changes - **BREAKING CHANGE**: None --- ### Additional Information - Scope intentionally excludes password-protected links, expiration controls, QR generation, custom slug, and permission-system redesign. - No new dependencies were introduced. - Backend verification command: - `pytest -q backend/open_webui/test/apps/webui/routers/test_chats.py` - Test result summary: - `9 passed` ### Screenshots or Videos - **Shared chats overview**: management modal with list, counters, search box, sort headers, and actions <img width="2248" height="817" alt="01-shared-chats-overview" src="https://github.com/user-attachments/assets/85a66717-1467-4161-8e76-ad531372c36c" /> - **Multi-select with total/selected counters**: row-level and page-level selections reflected in header counters <img width="2259" height="815" alt="02-shared-chats-multi-select（with totol count)" src="https://github.com/user-attachments/assets/64387cd7-16d9-4be9-b466-af063dd98eb8" /> - **Bulk unshare workflow**: selected shared chats revoked in one action <img width="2246" height="1485" alt="03-shared-chats-bulk-unshare" src="https://github.com/user-attachments/assets/8263995a-fcc3-47f3-8b5b-8c9cbaf47d03" /> - **Created at sorting behavior**: ordering of rows after `Created at` sort toggle <img width="2221" height="1646" alt="04-shared-chats-created-at-sort" src="https://github.com/user-attachments/assets/13fe00f1-4279-40ed-8d5d-f2a0e32939fe" /> - **Empty and no-result states**: clear feedback for no shared chats and no search match cases <img width="2256" height="651" alt="05-shared-chats-empty-state" src="https://github.com/user-attachments/assets/22377eb7-c846-4d51-b032-075611b6e09a" /> ### Contributor License Agreement  - [x] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-21 16:08:09 -05:00

GiteaMirror closed this issue

2026-05-21 16:08:15 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#131100