github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-07-16 06:03:26 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #23797] [CLOSED] perf(chats): avoid redundant fetch in get_chat_by_share_id #131040

New Issue
Closed
opened 2026-05-21 15:59:47 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-21 15:59:47 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/23797
Author: @Classic298
Created: 4/16/2026
Status: ❌ Closed

Base: dev ← Head: claude/optimize-chat-share-id-9ym0Z

📝 Commits (1)

  • a963bea perf(chats): avoid redundant fetch in get_chat_by_share_id

📊 Changes

1 file changed (+8 additions, -4 deletions)

View changed files

📝 backend/open_webui/models/chats.py (+8 -4)

📄 Description

get_chat_by_share_id already loads the Chat row via share_id lookup, then discarded it and re-fetched through get_chat_by_id. Drop the second query and return the row we already have, preserving the null-byte sanitization behavior inline.

Contributor License Agreement

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/23797 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 4/16/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `claude/optimize-chat-share-id-9ym0Z` --- ### 📝 Commits (1) - [`a963bea`](https://github.com/open-webui/open-webui/commit/a963bea8f555921123fdf12e7663fd8546a19234) perf(chats): avoid redundant fetch in get_chat_by_share_id ### 📊 Changes **1 file changed** (+8 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/models/chats.py` (+8 -4) </details> ### 📄 Description get_chat_by_share_id already loads the Chat row via share_id lookup, then discarded it and re-fetched through get_chat_by_id. Drop the second query and return the row we already have, preserving the null-byte sanitization behavior inline. ### Contributor License Agreement <!-- 🚨 DO NOT DELETE THE TEXT BELOW 🚨 Keep the "Contributor License Agreement" confirmation text intact. Deleting it will trigger the CLA-Bot to INVALIDATE your PR. Your PR will NOT be reviewed or merged until you check the box below confirming that you have read and agree to the terms of the CLA. --> - [X] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-21 15:59:47 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#131040
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?