[PR #22776] [MERGED] fix: align file context injection by user-role messages for native FC #130518

New Issue

GiteaMirror · 2026-05-21T14:47:17-05:00

GiteaMirror commented

2026-05-21 14:47:17 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/22776
Author: @Classic298
Created: 3/17/2026
Status: ✅ Merged
Merged: 3/25/2026
Merged by: @tjbck

Base: dev ← Head: fix/native-fc-image-edit-file-context

📝 Commits (1)

3323e18 fix: align file context injection by user-role messages for native FC

📊 Changes

1 file changed (+12 additions, -1 deletions)

View changed files

📝 backend/open_webui/utils/middleware.py (+12 -1)

📄 Description

The add_file_context function used a positional zip() to pair API payload messages with DB-stored messages. After
process_messages_with_output() expands assistant messages containing tool calls into multiple OpenAI-format messages (assistant + tool results), the payload list becomes longer than the stored list. This caused the zip to misalign, so subsequent user messages never received their attached_files tags -- the model could see uploaded images via vision but had no file URL to pass to edit_image.

Fix: filter both lists to user-role messages only before zipping. User messages maintain the same order in both lists regardless of assistant message expansion, restoring correct file context injection.

Fixes #21878

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/22776 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 3/17/2026 **Status:** ✅ Merged **Merged:** 3/25/2026 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/native-fc-image-edit-file-context` --- ### 📝 Commits (1) - [`3323e18`](https://github.com/open-webui/open-webui/commit/3323e1888eeb8d184b5fb190a1d48abf3b91bb8c) fix: align file context injection by user-role messages for native FC ### 📊 Changes **1 file changed** (+12 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/utils/middleware.py` (+12 -1) </details> ### 📄 Description The add_file_context function used a positional zip() to pair API payload messages with DB-stored messages. After process_messages_with_output() expands assistant messages containing tool calls into multiple OpenAI-format messages (assistant + tool results), the payload list becomes longer than the stored list. This caused the zip to misalign, so subsequent user messages never received their attached_files tags -- the model could see uploaded images via vision but had no file URL to pass to edit_image. Fix: filter both lists to user-role messages only before zipping. User messages maintain the same order in both lists regardless of assistant message expansion, restoring correct file context injection. Fixes #21878 ### Contributor License Agreement  - [X] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-21 14:47:17 -05:00

GiteaMirror closed this issue

2026-05-21 14:47:21 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#130518