[PR #22482] [CLOSED] chore: split lint and lint fix scripts #130378

Closed
opened 2026-05-21 14:27:33 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/22482
Author: @comeran
Created: 3/9/2026
Status: Closed

Base: devHead: dev


📝 Commits (1)

  • abfd998 chore: split lint and lint fix scripts

📊 Changes

2 files changed (+14 additions, -1 deletions)

View changed files

📝 package.json (+2 -1)
test/package-scripts.test.mjs (+12 -0)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request.

This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR.

Before submitting, make sure you've checked the following:

  • Target branch: Verify that the pull request targets the dev branch. PRs targeting main will be immediately closed.
  • Description: Provide a concise description of the changes made in this pull request down below.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: No user-facing behavior, environment variables, public APIs, or deployment steps were changed.
  • Dependencies: No new or upgraded dependencies were introduced.
  • Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Include reproducible steps to demonstrate the issue before the fix. Test edge cases (URL encoding, HTML entities, types). Take this as an opportunity to make screenshots of the feature/fix and include them in the PR description.
  • Agentic AI Code: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review AND manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
  • Code review: Self-review completed for this atomic change.
  • Design & Architecture: This change keeps the existing script layout and only separates read-only linting from autofix behavior.
  • Git Hygiene: This PR contains one logical change and was pushed on top of dev.
  • Title Prefix: PR title uses the chore prefix.

Changelog Entry

Description

  • Separate read-only linting from autofix behavior so npm run lint no longer mutates files while still preserving an explicit autofix command.

Added

  • A dedicated lint:fix script that runs eslint . --fix.
  • A regression test covering the package.json lint script definitions.

Changed

  • Updated lint:frontend to run eslint . without --fix.

Deprecated

  • None.

Removed

  • None.

Fixed

  • Prevented the default frontend lint command from modifying files during routine lint/check runs.

Security

  • None.

Breaking Changes

  • BREAKING CHANGE: None.

Additional Information

  • Before this change, npm run lint invoked lint:frontend, which ran eslint . --fix and could modify tracked files during a normal lint pass.
  • After this change:
    • npm run lint remains read-only for the frontend step.
    • npm run lint:fix must be used explicitly for autofix behavior.
  • Automated verification performed:
    • node --test test/package-scripts.test.mjs
    • git diff --check

Screenshots or Videos

  • Not applicable for this script-only change.

Contributor License Agreement

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/22482 **Author:** [@comeran](https://github.com/comeran) **Created:** 3/9/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `dev` --- ### 📝 Commits (1) - [`abfd998`](https://github.com/open-webui/open-webui/commit/abfd9985965bb1071ec47ef9eaa86d1038c56b5f) chore: split lint and lint fix scripts ### 📊 Changes **2 files changed** (+14 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `package.json` (+2 -1) ➕ `test/package-scripts.test.mjs` (+12 -0) </details> ### 📄 Description <!-- ⚠️ CRITICAL CHECKS FOR CONTRIBUTORS (READ, DON'T DELETE) ⚠️ 1. Target the `dev` branch. PRs targeting `main` will be automatically closed. 2. Do NOT delete the CLA section at the bottom. It is required for the bot to accept your PR. --> # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request. This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Verify that the pull request targets the `dev` branch. **PRs targeting `main` will be immediately closed.** - [x] **Description:** Provide a concise description of the changes made in this pull request down below. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** No user-facing behavior, environment variables, public APIs, or deployment steps were changed. - [x] **Dependencies:** No new or upgraded dependencies were introduced. - [x] **Testing:** Perform manual tests to **verify the implemented fix/feature works as intended AND does not break any other functionality**. Include reproducible steps to demonstrate the issue before the fix. Test edge cases (URL encoding, HTML entities, types). Take this as an opportunity to **make screenshots of the feature/fix and include them in the PR description**. - [x] **Agentic AI Code:** Confirm this Pull Request is **not written by any AI Agent** or has at least **gone through additional human review AND manual testing**. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [x] **Code review:** Self-review completed for this atomic change. - [x] **Design & Architecture:** This change keeps the existing script layout and only separates read-only linting from autofix behavior. - [x] **Git Hygiene:** This PR contains one logical change and was pushed on top of `dev`. - [x] **Title Prefix:** PR title uses the `chore` prefix. # Changelog Entry ### Description - Separate read-only linting from autofix behavior so `npm run lint` no longer mutates files while still preserving an explicit autofix command. ### Added - A dedicated `lint:fix` script that runs `eslint . --fix`. - A regression test covering the `package.json` lint script definitions. ### Changed - Updated `lint:frontend` to run `eslint .` without `--fix`. ### Deprecated - None. ### Removed - None. ### Fixed - Prevented the default frontend lint command from modifying files during routine lint/check runs. ### Security - None. ### Breaking Changes - **BREAKING CHANGE**: None. --- ### Additional Information - Before this change, `npm run lint` invoked `lint:frontend`, which ran `eslint . --fix` and could modify tracked files during a normal lint pass. - After this change: - `npm run lint` remains read-only for the frontend step. - `npm run lint:fix` must be used explicitly for autofix behavior. - Automated verification performed: - `node --test test/package-scripts.test.mjs` - `git diff --check` ### Screenshots or Videos - Not applicable for this script-only change. ### Contributor License Agreement <!-- 🚨 DO NOT DELETE THE TEXT BELOW 🚨 Keep the "Contributor License Agreement" confirmation text intact. Deleting it will trigger the CLA-Bot to INVALIDATE your PR. Your PR will NOT be reviewed or merged until you check the box below confirming that you have read and agree to the terms of the CLA. --> - [x] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-21 14:27:33 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#130378