[PR #22473] [MERGED] fix: replace bare except with except Exception #130374

New Issue

GiteaMirror · 2026-05-21T14:27:15-05:00

GiteaMirror commented

2026-05-21 14:27:15 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/22473
Author: @gambletan
Created: 3/9/2026
Status: ✅ Merged
Merged: 3/15/2026
Merged by: @tjbck

Base: dev ← Head: fix-bare-except

📝 Commits (1)

66e49ce fix: replace bare except with except Exception

📊 Changes

9 files changed (+14 additions, -14 deletions)

View changed files

📝 backend/open_webui/retrieval/loaders/external_document.py (+1 -1)
📝 backend/open_webui/retrieval/loaders/mineru.py (+3 -3)
📝 backend/open_webui/retrieval/vector/dbs/chroma.py (+1 -1)
📝 backend/open_webui/routers/chats.py (+1 -1)
📝 backend/open_webui/routers/configs.py (+1 -1)
📝 backend/open_webui/routers/pipelines.py (+2 -2)
📝 backend/open_webui/routers/retrieval.py (+1 -1)
📝 backend/open_webui/socket/main.py (+1 -1)
📝 backend/open_webui/utils/middleware.py (+3 -3)

📄 Description

Description

Replace bare except clauses with except Exception to follow Python best practices and avoid catching unexpected system exceptions like KeyboardInterrupt and SystemExit.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/22473 **Author:** [@gambletan](https://github.com/gambletan) **Created:** 3/9/2026 **Status:** ✅ Merged **Merged:** 3/15/2026 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix-bare-except` --- ### 📝 Commits (1) - [`66e49ce`](https://github.com/open-webui/open-webui/commit/66e49ce407d0baa218b3d8d23827ae5b43139a04) fix: replace bare except with except Exception ### 📊 Changes **9 files changed** (+14 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/retrieval/loaders/external_document.py` (+1 -1) 📝 `backend/open_webui/retrieval/loaders/mineru.py` (+3 -3) 📝 `backend/open_webui/retrieval/vector/dbs/chroma.py` (+1 -1) 📝 `backend/open_webui/routers/chats.py` (+1 -1) 📝 `backend/open_webui/routers/configs.py` (+1 -1) 📝 `backend/open_webui/routers/pipelines.py` (+2 -2) 📝 `backend/open_webui/routers/retrieval.py` (+1 -1) 📝 `backend/open_webui/socket/main.py` (+1 -1) 📝 `backend/open_webui/utils/middleware.py` (+3 -3) </details> ### 📄 Description ## Description Replace bare except clauses with `except Exception` to follow Python best practices and avoid catching unexpected system exceptions like `KeyboardInterrupt` and `SystemExit`. ### Contributor License Agreement - [x] By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-21 14:27:15 -05:00

GiteaMirror closed this issue

2026-05-21 14:27:18 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#130374