[PR #21742] [MERGED] fix(ui): allow empty LDAP Application DN value and password in General setting… #129913

New Issue

GiteaMirror · 2026-05-21T13:34:18-05:00

GiteaMirror commented

2026-05-21 13:34:18 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/21742
Author: @j-frei
Created: 2/22/2026
Status: ✅ Merged
Merged: 2/22/2026
Merged by: @tjbck

Base: dev ← Head: dev

📝 Commits (2)

35135b2 Allow empty LDAP Application DN value and password in General settings form
e1fa42d fix(ui): use LDAP app_dn, app_dn_password with empty string instead of enforcing non-empty values

📊 Changes

2 files changed (+3 additions, -5 deletions)

View changed files

📝 backend/open_webui/routers/auths.py (+2 -4)
📝 src/lib/components/admin/Settings/General.svelte (+1 -1)

📄 Description

Pull Request: Allow empty LDAP Application DN and password in General settings form

Description

This pull request allows the LDAP Application DN and its password fields in the General settings form to accept empty strings. Previously, the DN field was required, which prevented saving the form with an empty value. The password input now explicitly sets required={false} to allow empty passwords when needed.

Changelog Entry

Fixed

Allow empty values for LDAP Application DN and password in General settings form.
Removed required from the Application DN input field.
Set required={false} on SensitiveInput for the password field to permit empty input.

Added

None

Changed

LDAP settings form input behavior for DN and password fields.

Deprecated

None

Removed

None

Security

None

Breaking Changes

None

Additional Information

This PR ensures that empty LDAP DN or password values can be submitted in the General settings form.
Manual testing confirms that leaving these fields empty no longer triggers HTML5 validation errors and the form submits correctly.

Screenshots or Videos

None

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/21742 **Author:** [@j-frei](https://github.com/j-frei) **Created:** 2/22/2026 **Status:** ✅ Merged **Merged:** 2/22/2026 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `dev` --- ### 📝 Commits (2) - [`35135b2`](https://github.com/open-webui/open-webui/commit/35135b262cd1eacdf89af6f27e2f844e0b116bdb) Allow empty LDAP Application DN value and password in General settings form - [`e1fa42d`](https://github.com/open-webui/open-webui/commit/e1fa42d48a15c8b496a887ecfa32fc01cfd74b36) fix(ui): use LDAP app_dn, app_dn_password with empty string instead of enforcing non-empty values ### 📊 Changes **2 files changed** (+3 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/auths.py` (+2 -4) 📝 `src/lib/components/admin/Settings/General.svelte` (+1 -1) </details> ### 📄 Description # Pull Request: Allow empty LDAP Application DN and password in General settings form  ### Description This pull request allows the LDAP Application DN and its password fields in the General settings form to accept empty strings. Previously, the DN field was required, which prevented saving the form with an empty value. The password input now explicitly sets `required={false}` to allow empty passwords when needed. --- ### Changelog Entry ### Fixed - Allow empty values for LDAP Application DN and password in General settings form. - Removed `required` from the Application DN input field. - Set `required={false}` on `SensitiveInput` for the password field to permit empty input. --- ### Added - None ### Changed - LDAP settings form input behavior for DN and password fields. ### Deprecated - None ### Removed - None ### Security - None ### Breaking Changes - None --- ### Additional Information - This PR ensures that empty LDAP DN or password values can be submitted in the General settings form. - Manual testing confirms that leaving these fields empty no longer triggers HTML5 validation errors and the form submits correctly. ### Screenshots or Videos - None ### Contributor License Agreement  By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-21 13:34:18 -05:00

GiteaMirror closed this issue

2026-05-21 13:34:23 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#129913