github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-07-16 14:39:31 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #21705] [MERGED] fix(a11y): add aria-hidden to all decorative SVG icon components #129880

New Issue
Closed
opened 2026-05-21 13:31:40 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-21 13:31:40 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/21705
Author: @Classic298
Created: 2/21/2026
Status: ✅ Merged
Merged: 2/21/2026
Merged by: @tjbck

Base: dev ← Head: a11y/icons-aria-hidden

📝 Commits (1)

  • 9e23bd5 fix(a11y): add aria-hidden to all decorative SVG icon components

📊 Changes

112 files changed (+112 additions, -19 deletions)

View changed files

📝 src/lib/components/icons/AdjustmentsHorizontal.svelte (+1 -0)
📝 src/lib/components/icons/AdjustmentsHorizontalOutline.svelte (+1 -0)
📝 src/lib/components/icons/ArrowDownTray.svelte (+1 -0)
📝 src/lib/components/icons/ArrowForward.svelte (+1 -0)
📝 src/lib/components/icons/ArrowLeft.svelte (+1 -0)
📝 src/lib/components/icons/ArrowLeftTag.svelte (+1 -0)
📝 src/lib/components/icons/ArrowPath.svelte (+1 -0)
📝 src/lib/components/icons/ArrowRight.svelte (+1 -0)
📝 src/lib/components/icons/ArrowRightCircle.svelte (+1 -0)
📝 src/lib/components/icons/ArrowRightTag.svelte (+1 -0)
📝 src/lib/components/icons/ArrowTurnDownRight.svelte (+1 -1)
📝 src/lib/components/icons/ArrowUpCircle.svelte (+1 -0)
📝 src/lib/components/icons/ArrowUpLeft.svelte (+1 -0)
📝 src/lib/components/icons/ArrowUpTray.svelte (+1 -0)
📝 src/lib/components/icons/ArrowUturnLeft.svelte (+1 -0)
📝 src/lib/components/icons/ArrowUturnRight.svelte (+1 -0)
📝 src/lib/components/icons/ArrowsPointingOut.svelte (+1 -0)
📝 src/lib/components/icons/Bars3BottomLeft.svelte (+1 -1)
📝 src/lib/components/icons/BarsArrowUp.svelte (+1 -0)
📝 src/lib/components/icons/Bold.svelte (+1 -0)

...and 80 more files

📄 Description

Add aria-hidden='true' to 112 SVG icon components in src/lib/components/icons/ that were missing this attribute. Decorative icons that convey no semantic meaning should be hidden from the accessibility tree to prevent screen readers from attempting to read meaningless SVG markup (WCAG 1.1.1 Non-text Content, WCAG 4.1.2 Name, Role, Value).

The remaining 60 icon files already had aria-hidden='true' set. All 172 icon components now consistently declare aria-hidden='true' on their root svg element.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/21705 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 2/21/2026 **Status:** ✅ Merged **Merged:** 2/21/2026 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `a11y/icons-aria-hidden` --- ### 📝 Commits (1) - [`9e23bd5`](https://github.com/open-webui/open-webui/commit/9e23bd5cde7e0a8b5892ac4546b947e066bf6c8c) fix(a11y): add aria-hidden to all decorative SVG icon components ### 📊 Changes **112 files changed** (+112 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/icons/AdjustmentsHorizontal.svelte` (+1 -0) 📝 `src/lib/components/icons/AdjustmentsHorizontalOutline.svelte` (+1 -0) 📝 `src/lib/components/icons/ArrowDownTray.svelte` (+1 -0) 📝 `src/lib/components/icons/ArrowForward.svelte` (+1 -0) 📝 `src/lib/components/icons/ArrowLeft.svelte` (+1 -0) 📝 `src/lib/components/icons/ArrowLeftTag.svelte` (+1 -0) 📝 `src/lib/components/icons/ArrowPath.svelte` (+1 -0) 📝 `src/lib/components/icons/ArrowRight.svelte` (+1 -0) 📝 `src/lib/components/icons/ArrowRightCircle.svelte` (+1 -0) 📝 `src/lib/components/icons/ArrowRightTag.svelte` (+1 -0) 📝 `src/lib/components/icons/ArrowTurnDownRight.svelte` (+1 -1) 📝 `src/lib/components/icons/ArrowUpCircle.svelte` (+1 -0) 📝 `src/lib/components/icons/ArrowUpLeft.svelte` (+1 -0) 📝 `src/lib/components/icons/ArrowUpTray.svelte` (+1 -0) 📝 `src/lib/components/icons/ArrowUturnLeft.svelte` (+1 -0) 📝 `src/lib/components/icons/ArrowUturnRight.svelte` (+1 -0) 📝 `src/lib/components/icons/ArrowsPointingOut.svelte` (+1 -0) 📝 `src/lib/components/icons/Bars3BottomLeft.svelte` (+1 -1) 📝 `src/lib/components/icons/BarsArrowUp.svelte` (+1 -0) 📝 `src/lib/components/icons/Bold.svelte` (+1 -0) _...and 80 more files_ </details> ### 📄 Description Add aria-hidden='true' to 112 SVG icon components in src/lib/components/icons/ that were missing this attribute. Decorative icons that convey no semantic meaning should be hidden from the accessibility tree to prevent screen readers from attempting to read meaningless SVG markup (WCAG 1.1.1 Non-text Content, WCAG 4.1.2 Name, Role, Value). The remaining 60 icon files already had aria-hidden='true' set. All 172 icon components now consistently declare aria-hidden='true' on their root svg element. ### Contributor License Agreement <!-- 🚨 DO NOT DELETE THE TEXT BELOW 🚨 Keep the "Contributor License Agreement" confirmation text intact. Deleting it will trigger the CLA-Bot to INVALIDATE your PR. --> By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-21 13:31:40 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#129880
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?