[PR #20453] [CLOSED] refactor: extract showSuccessToast helper in Settings #129285

New Issue

GiteaMirror · 2026-05-21T12:27:25-05:00

GiteaMirror commented

2026-05-21 12:27:25 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/20453
Author: @silentoplayz
Created: 1/7/2026
Status: ❌ Closed

Base: dev ← Head: refactor/settings-toast

📝 Commits (1)

d9c6f40 refactor(admin): extract showSuccessToast helper in Settings

📊 Changes

1 file changed (+14 additions, -10 deletions)

View changed files

📝 src/lib/components/admin/Settings.svelte (+14 -10)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request.

This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR.

Before submitting, make sure you've checked the following:

Target branch: Verify that the pull request targets the dev branch. Not targeting the dev branch will lead to immediate closure of the PR.
Description: Provide a concise description of the changes made in this pull request down below.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: If necessary, update relevant documentation Open WebUI Docs like environment variables, the tutorials, or other documentation sources.
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description.
Agentic AI Code: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review AND manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- refactor: Code restructuring for better maintainability, readability, or scalability

Changelog Entry

Description

Refactored the Admin Settings component to reduce code duplication by extracting repeated toast notifications into a helper function.

Added

Created showSuccessToast helper function in Settings.svelte to standardize success messages.

Changed

Replaced multiple instances of toast.success($i18n.t('Settings saved successfully!')) with the new valid helper function.
Verified that all settings save actions still trigger the correct toast notification.

Removed

Removed redundant/duplicate code blocks for toast notifications.

Additional Information

This change addresses a DRY (Don't Repeat Yourself) violation in the settings component where the same toast message logic was repeated multiple times. It makes future updates to the success message easier as it's now defined in a single location.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/20453 **Author:** [@silentoplayz](https://github.com/silentoplayz) **Created:** 1/7/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `refactor/settings-toast` --- ### 📝 Commits (1) - [`d9c6f40`](https://github.com/open-webui/open-webui/commit/d9c6f40c52aff36305025ee1e64ba096047faf8d) refactor(admin): extract showSuccessToast helper in Settings ### 📊 Changes **1 file changed** (+14 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/admin/Settings.svelte` (+14 -10) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request. This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Verify that the pull request targets the `dev` branch. **Not targeting the `dev` branch will lead to immediate closure of the PR.** - [x] **Description:** Provide a concise description of the changes made in this pull request down below. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** If necessary, update relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs) like environment variables, the tutorials, or other documentation sources. - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Perform manual tests to **verify the implemented fix/feature works as intended AND does not break any other functionality**. Take this as an opportunity to **make screenshots of the feature/fix and include it in the PR description**. - [x] **Agentic AI Code:** Confirm this Pull Request is **not written by any AI Agent** or has at least **gone through additional human review AND manual testing**. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **refactor**: Code restructuring for better maintainability, readability, or scalability # Changelog Entry ### Description Refactored the Admin Settings component to reduce code duplication by extracting repeated toast notifications into a helper function. ### Added - Created `showSuccessToast` helper function in `Settings.svelte` to standardize success messages. ### Changed - Replaced multiple instances of `toast.success($i18n.t('Settings saved successfully!'))` with the new valid helper function. - Verified that all settings save actions still trigger the correct toast notification. ### Removed - Removed redundant/duplicate code blocks for toast notifications. --- ### Additional Information This change addresses a DRY (Don't Repeat Yourself) violation in the settings component where the same toast message logic was repeated multiple times. It makes future updates to the success message easier as it's now defined in a single location. ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-21 12:27:25 -05:00

GiteaMirror closed this issue

2026-05-21 12:27:27 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#129285